NASAWorldWind / WorldWindAndroid

The NASA WorldWind Java SDK for Android (WWA) includes the library, examples and tutorials for building 3D virtual globe applications for phones and tablets.
Other
266 stars 125 forks source link

Clipped Atmosphere Layer #1

Closed ndorigatti closed 7 years ago

ndorigatti commented 8 years ago

It seems that Atmoshpere Layer is clipped the wrong way sometimes. Here it is in the CameraView example a couple of screenshots showing it (Using Nexus6p or Motorola MotoX with Android M both).

Just opened CameraView example and rotated a bit on left-right from the default view.

screenshot_20160331-124355 screenshot_20160331-124434

pdavidc commented 8 years ago

Nicola, Thanks for bringing this to our attention. Just to clarify, the atmosphere layer is an experimental feature in the examples project that we're still developing. We'll be sure to look into this.

ndorigatti commented 8 years ago

ah-ha I see now why! Then it's ok. Thanks for the feedback, and let me say that v0.1 is very good and smooth! As soon as i have some time I will try to customize a bit the examples and give some feedback.

pdavidc commented 7 years ago

@ndorigatti Would you please try the latest code in the develop branch, and let us know whether or not the issue is fixed?

ndorigatti commented 7 years ago

@pdavidc I can't check from the source code, but I've downloaded the tutorials apk from the latest daily build (3101) and I don't see the atmosphere layer, so can't confirm regarding the issue. Anyway, i tried the basic globe in examples that have the atmosphere layer and I can't see the issue there 👍

ComBatVision commented 7 years ago

@pdavidc Will Atmosphere layer go inside of worldwind.aar in case of successfully bug fix?

pdavidc commented 7 years ago

@ndorigatti Thank you for checking. The examples APK from the daily build contains the fixed atmosphere layer. Given that, I'll consider this issue fixed.

@Sufaev We'll evaluate this layer for inclusion in the core library.