ComBatVision
commented
7 years ago Here is my fully functional prototype of changes to make rotation and tilt work both with 2 fingers. This behavior of gestures is more user-friendly and support more devices.
public class CustomWorldWindowController extends BasicWorldWindowController {
public CustomWorldWindowController() {
// Recognize tilt with 2 fingers instead of 3
((PanRecognizer)tiltRecognizer).setMinNumberOfPointers(2);
}
@Override
public boolean onTouchEvent(MotionEvent event) {
boolean handled = false;
int action = event.getActionMasked();
for(GestureRecognizer recognizer : allRecognizers) {
if(!isSkipped(recognizer)) {
handled |= recognizer.onTouchEvent(event);
// Skip dependent gestures
if (recognizer.getState() == WorldWind.CHANGED) {
if (recognizer == tiltRecognizer) {
skipRotation();
} else if (recognizer == rotationRecognizer) {
skipTilt();
}
}
} else if(action == MotionEvent.ACTION_UP || action == MotionEvent.ACTION_CANCEL) {
// Reset skip flag to enable gesture processing next time
if (recognizer == rotationRecognizer) {
rotationSkipped = false;
} else if (recognizer == tiltRecognizer) {
tiltSkipped = false;
}
}
}
return handled;
}
private boolean isSkipped(GestureRecognizer recognizer) {
if(recognizer == rotationRecognizer) {
return rotationSkipped;
} else if(recognizer == tiltRecognizer) {
return tiltSkipped;
} else {
return false;
}
}
private void skipRotation() {
if(!rotationSkipped) {
cancel(rotationRecognizer);
rotationSkipped = true;
}
}
private void skipTilt() {
if(!tiltSkipped) {
cancel(tiltRecognizer);
tiltSkipped = true;
}
}
private void cancel(GestureRecognizer recognizer) {
// It is not possible to call handleActionCancel from here, so emulate Cancel event
recognizer.onTouchEvent(MotionEvent.obtain(0, 0, MotionEvent.ACTION_CANCEL, 0, 0, 0));
}
// We need external skip state flags, because GestureRecogniser reset state to POSSIBLE directly after setting CANCEL or FAILED
// If gestures will be able to remember last state until next ACTION_DOWN event,
// than we may use state analysis instead of external flags
private boolean rotationSkipped;
private boolean tiltSkipped;
}
jgiovino
Hello!
Some phones does not support detection of movement for more than 2 fingers, plus 3 finger gesture is not obvious.
I propose to modify BasicWorldWindController to set 2 fingers for tiltRecognizer.
This gives much better user experience. User can tilt, pan and zoom together with one gesture. Please try to test it. You will like this behavior.
UPD!!! This modification broke the rotation gesture, but it will be good to find solution to make them work like in GoogleMaps. If rotation was first, than tilt should be disabled during this gesture.