Closed Keithsc closed 6 years ago
Same problem for me. I am not an expert in python, but I got the right result if I comment line #967 ... all_vms.remove(vm) ...
Can you try at least with preview mode.
Commenting out the "all_vms.remove(vm)" line appears to have fixed this issue for us!. I only tried this on one of our xenserver pools and that was just using preview mode as you suggested but the outputted VM count is correct now and that included an excluded VM.
I have started a backup job now and will report back on how it goes but it's looks good so far. I hope this fixes this as I really want to schedule theses jobs but can't if VM's are being moved around.
Anyway, good find. Thanks.
same issue for me... skip one vm with . (for example MC. sikkiping one vm in backup). Commenting out line as above it works!
Thank you for the notes on this. Did you try running the script without defining any defaults to see if it picks up all VMs? Or did you try this with vm-export=".*" to see if that makes a difference? You should be able to verify this using the "preview" option.
Hi, We just ran the script with vm-export=".*" in the config. The script has run a few times now on our four xenserver pools (v7.0) and it appears to be working well :>)
On 04/05/17 06:11, NAUbackup wrote:
Thank you for the notes on this. Did you try running the script without defining any defaults to see if it picks up all VMs? Or did you try this with vm-export=".*" to see if that makes a difference?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/NAUbackup/VmBackup/issues/36#issuecomment-299098249, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFUXkBVmqDgR0U9jjLN90oUWlwUjbKlwks5r2V4agaJpZM4MaNsg.
This message may contain confidential information. If you are not the intended recipient please inform the sender that you have received the message in error before deleting it. Please do not disclose, copy or distribute information in this e-mail or take any action in reliance on its contents: to do so is strictly prohibited and may be unlawful.
Thank you for your co-operation.
NHSmail is the secure email and directory service available for all NHS staff in England and Scotland NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and other accredited email services. NHSmail provides an email address for your career in the NHS and can be accessed anywhere For more information and to find out how you can switch, visit http://support.nhs.net/joiningnhsmail
Thanks, @Keithsc -- I would also be interested if you leave off any "vm-export=." definition if by default it picks up every VM? I get no VMs picked up. If you could check that also, I can then update the documentation and close this thread. I am concerned that the changes proposed above might create other undesirable effects.
Also, I get it to work fine with .* used without quotes, and if I use quotes, it does not pick any VMs at all. Hmmm. This is on XenServer 6.5 SP1 as well as 7.1 and using NAUbackup VMbackup 3.1. In other words, I do not get the same behavior as you.
Is the vm-export line the very last one in the cfg file? Could you perhaps post your cfg file and/or the output from:
./VmBackup.py PASSWORD YOUR.cfg preview ignore_extra_keys=true
obviously with the PASSWORD obfuscated and using your cfg file? I can get all VMs listed, even if containing multiple spaces.
Many thanks! --Tobias
Meanwhile, I have verified this issue and fix. We will be doing a bit more testing and looking at a minor version release in the near future to incorporate this plus possibly a few other features. Thank you for your contributions and patience. --Tobias
Fixed and incorporated into V3.2.
Hi, We can't get the vm-export = .* command to work correctly in any of the XenServer pools and wondered if someone could help us ?
Below is out Pool-1.cnf pool_db_backup=1 max_backups=4 backup_dir=/run/sr-mount/uuid/BACKUPS status_log=/run/sr-mount/uuid/NAUbackup/logs/Pool-1.log vdi_export_format=raw vm-export= .*
Running the above config with preview only give us 21 virtual servers although there are 41 live VM's [root@xen-01 NAUbackup]# ./VmBackup.py Pool-1.pass test.cfg preview 2017-03-22-(10:00:54) - VmBackup config loaded from: test.cfg 2017-03-22-(10:00:54) - VmBackup.py running with these settings: 2017-03-22-(10:00:54) - backup_dir = /run/sr-mount/uuid/BACKUPS 2017-03-22-(10:00:54) - status_log = /run/sr-mount/uuid/NAUbackup/logs/Pool-1.log 2017-03-22-(10:00:54) - compress = False 2017-03-22-(10:00:54) - max_backups = 4 2017-03-22-(10:00:54) - vdi_export_format = raw 2017-03-22-(10:00:54) - pool_db_backup = 1 2017-03-22-(10:00:54) - exclude (cnt)= 0 2017-03-22-(10:00:54) - exclude: 2017-03-22-(10:00:54) - vdi-export (cnt)= 0 2017-03-22-(10:00:54) - vdi-export: 2017-03-22-(10:00:54) - vm-export (cnt)= 21 2017-03-22-(10:00:54) - vm-export: A.domain.com, B.domain.com, C.domain.com, D.domain.com, E.domain.com, F.domain.com, G.domain.com, G.domain.com, H.domain.com, I.domain.com, J.domain.com, K.domain.com, L.domain.com, M.domain.com, N.domain.com, O.domain.com, P.domain.com, Q.domain.com, R.domain.com, S.domain.com, T.domain.com 2017-03-22-(10:00:54) - SUCCESS preview of parameters
As you can see we have 41 servers. [root@xen-01 NAUbackup]# xe vm-list | grep name-label | grep -v Control | wc -l 41
To get the script to work for us just now we are manually specifying each VM and this works but we would prefer to use the wild-card option so hopefully someone can help.
Thanks Keith