search

NAUbackup / VmBackup

XenServer simple backup script
228 stars 61 forks source link

Feature request: Test email configuration in the pre-check #72

Open VARGA-Peter opened 6 years ago

VARGA-Peter commented 6 years ago

Guys, great you have done here! This is finally the backup solution I was looking for. Thx to Tobias for the link in the Citrix forum.

May be you can re-consider the email treatment. It is very important for scheduled tasks to be informed. Could you extract the email-settings from the python source into the .cfg file and add a command line option which tests the email settings with a test email?

Kind regards and thank you so much!

NAUbackup commented 6 years ago

Peter, Any code changes you wish to submit for incorporation will certainly be taken into consideration and though these days I am limited in the time I can invest as I lost a co-worker who was helping with some development a few months ago, I will strive to do what I can. Thanks!

--Tobias

VARGA-Peter commented 6 years ago

If you don't mind I can try to program this pre-check and submit it to you via email. You can then decide if it meets your expectations - I never programmed in Python but I am a programmer for 30 years so I should be capable to do it.

But please understand should it be programmed too complicated due to missing Python knowledge...

OR

When you decide to add #74 to the package then it would be already done because my example is totally stand alone. The user has only to copy the changes from the test file into VmBackup.py

Just let me know...

NAUbackup commented 6 years ago

Hi, Peter: I should be able to incorporate that code as a module pretty easily. I try to incorporate multiple features before releasing an official new release, but would be more than happy to send you a preview version to test if you'd be willing to give it a go. I'm not sure what my load will be this week overall, but let me see what I may be able to accomplish. Thanks for your feedback -- it is truly appreciated. I just got back into town from a meeting, and will see if I can at least give things a quick review tomorrow to get an idea of the scope. Injecting code isn't always so easy if it has to integrate within the current logic flow. We'll see how it looks like in terms of time resources. --Tobias

NAUbackup commented 6 years ago

Will try to tackle this next. Putting email configurations optionally into the configuration file makes good sense.