NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.
Other
10 stars 5 forks source link

VX Rings - Columns not matched #836

Closed missyschoenbaum closed 6 years ago

missyschoenbaum commented 6 years ago

I am seeing this in the CMD window, but I am not sure where the error happens. The column names that are not matching are related to the new functionality. Could we need a new table to capture these? Or do we have another sort of problem here.

If just capturing output is problem, let's make some improvements in the process that may cross reference other issue. Just figure out scope before you jump in.

missyschoenbaum commented 6 years ago

Here are some screenshots with as many iterations as I could capture from CMD. VX_rings_CMD_windows_errors.docx

BryanHurst commented 6 years ago

This also highlights the error for Issue 8 over on the CEngine.

This is good output to have.

BryanHurst commented 6 years ago

To make things a bit easier, Missy's above images are attached directly below.

image

image

image

image

BryanHurst commented 6 years ago

I'm not able to find references to any of these fields in the frontend or the CEngine.

My best guess is that the frontend is missing new fields that are required.

Need somebody to look deeply into the CEngine to see what is required and what we are missing.

ndh2 commented 6 years ago

These appear to be a holdover because we had a single list of "Reasons for control action" that was used for outputs related to vaccination and depopulation.

Here we're seeing combinations that make no sense (depopulation will never occur for the reason "it's part of a vaccination ring"). So we need to weed out those nonsensical combinations.

ndh2 commented 6 years ago

Uploaded a potential fix for this issue. https://github.com/NAVADMC/ADSM-CEngine/commit/5ad2e83424d517afd94f712776b651dff5b569ad

missyschoenbaum commented 6 years ago

This appears to be working. Output is not throwing fields into cmd window. Do I have field level checks that need to happen on this, meaning is it filling the database correctly?

missyschoenbaum commented 6 years ago

@ndh2 is there a way I am supposed to know which Vx ring type was used? Is there a new field?

ndh2 commented 6 years ago

@missyschoenbaum do you mean when looking in the output? What outputs do you see right now concerning vaccination?

missyschoenbaum commented 6 years ago

@ndh2 Here are all, but I think only the first 4 apply to this question. vaccURing, vaccARing, vacnURing, vacnARing,

firstVaccination, firstVaccinationRing, vaccU, vaccUIni, vacnU, vacnUIni, vacwU, vacwUDaysInQueue, vacwUMax, vacwUMaxDay, vacwUTimeAvg, vacwUTimeMax, -- Vaccination by Animal vaccA, vaccAIni, vacnA, vacnAIni, vacwA, vacwADaysInQueue, vacwAMax, vacwAMaxDay, vacwATimeAvg, vacwATimeMax From daily_controls vaccOccurred, vaccTriggered, -- Costs vaccVaccination, vaccSetup, vaccSubtotal,

missyschoenbaum commented 6 years ago

Asking @lkholmstrom about implementing specific outputs

ndh2 commented 6 years ago

The question came up today of whether you can use suppressive and protective (donut) rings at the same time. You can--we talked about how to implement it here: https://github.com/NAVADMC/ADSM/wiki/RFC-20121101:-New-Vaccination-Priorities#figure-4

missyschoenbaum commented 6 years ago

We will leave this as is for now. Can revisit later if needed.