search

NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.
Other
10 stars 5 forks source link

Summary Report - Remove TSD fields #895

Closed missyschoenbaum closed 5 years ago

missyschoenbaum commented 6 years ago

The transition state daily fields are showing up in the summary report. Can we remove those? They don't make sense. I think we need transition state cumulative there instead, but I need to dig around on that. I didn't want to forget this. Don't take action until I update.

missyschoenbaum commented 6 years ago

OK, I think this becomes a question for @ndh2 . I can find transition state daily X in Results_DailybyProductionType. However, we can't use those fields to calculate transition state cumulative, as a unit would get counted multiple times if it stayed in a disease state more than one day, which is likely.

How was this done for NAADSM? I can see there is a definition for transition state cumulative X in the field definitions.

missyschoenbaum commented 6 years ago

Next part of this, all transition state daily need to be removed from the summary report, regardless of getting transition state cumulative in the right place.

ndh2 commented 5 years ago

@missyschoenbaum Is getting counted multiple times bad? I guess it depends on the intended meaning of the variable. If this variable is like person-hours for work then it makes sense: like if 1 person works 3 hours and another works 5 hours, that's 8-person hours spent working. Same with this, if 1 unit spends 3 days clinical and another spends 5 days clinical, that's 8 unit-days spent in the clinical state. What meaning do you want from this variable?

missyschoenbaum commented 5 years ago

@ndh2 Either way we go, it will be hard to describe what we have intended. It's possible for the user to sum all the records if they want the unit-days. Let's not worry about putting any transition state variables into the summary. I think that sends this back to @BryanHurst to simply removing the fields in the summary.

missyschoenbaum commented 5 years ago

Looks great!