Beta Build 3.5.9.x Testing

[BryanHurst]

Vaccination Rings has been merged back into master and built as a Beta release.

We should do all testing in the Beta Build application.
Remember that you will now have a new Workspace folder called "ADSM Beta Workspace".

Merging into master removed the security warning on GitHub. Developers should keep an eye out for any future security warnings due to outdated/vulnerable package requirements in Requirements.txt.
In general, a warning will show up on the GitHub main page for the repo.

[BryanHurst]

It might be useful to know the changes from the last Production build to this Beta release candidate.

https://github.com/NAVADMC/ADSM/compare/v3.3.8.6...v3.3.9.17-beta

[BryanHurst]

The Beta build has now been promoted to Production: https://github.com/NAVADMC/ADSM/releases/tag/v3.5.9.19

[missyschoenbaum]

It is installing to a directory other than the one I request, and then it is unhappy.

[missyschoenbaum]

Should I be leaving it blank?

[BryanHurst]

That step is specifying where you want the workspace. Currently you are saying to store all the databases in the folder called documents. The problem with that is there will be other files and folders already in the Documents folder. You should add one more name to that path like "my adsm workspace"

On Mon, Nov 12, 2018, 8:41 PM Missy Schoenbaum <notifications@github.com wrote:

It is installing to a directory other than the one I request, and then it is unhappy. [image: dirlocation] https://user-images.githubusercontent.com/6644604/48389555-32c76000-e6bb-11e8-9fba-145fc35e533b.png

[image: error message] https://user-images.githubusercontent.com/6644604/48389561-38bd4100-e6bb-11e8-86bf-6f29b4085af9.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/NAVADMC/ADSM/issues/904#issuecomment-438122058, or mute the thread https://github.com/notifications/unsubscribe-auth/ABILBUl9MWG2cD7derXetK1feXmASW6sks5uuj9fgaJpZM4YQ58a .

[BryanHurst]

@missyschoenbaum did changing the path to "C:\Users\Mark\Documents\ADSM Production Workspace" fix the issue?

You could also leave it blank if you wanted it to automatically go to "C:\Users\Mark\Documents\ADSM Workspace"

[missyschoenbaum]

Yes, I had to wait for IT to install it on my work PC. On my home PC, I set a directory and it worked. I did find that the Sample Scenario is not converting the Unit ID, meaning that Unit ID is blank. This makes any daily outputs come out will a null value in the ID fields. I can write a known bug for it.

[missyschoenbaum]

I put in #908 to address this in known bugs. Is there not a way as we build the databases that we could populate this instead of using a conversion from user_notes to Unit_ID? It is the same value that is in the ID field in this case.

Import and replace are working fine, so most business cases would be working.

[BryanHurst]

We may need to do some installation testing when the program is not installed in the default location. I have somebody that reported an installer error when going into a folder not under Program Files.

[missyschoenbaum]

Can we get Conrad to try this also? Or to recruit a tester friend? I can try from home.

[BryanHurst]

@ConradSelig and @missyschoenbaum you may need to run the simulation to run into issues when installed in another location on the disk.
I think there might be an issue with the CEngine compile process that is statically linking a location.

[ConradSelig]

Got back from one of the two guys I set off on this task. He did WAY more than I expected him to, compiling a 4 page PDF of notes on 14 different installation cases he tried. Here is the PDF:

ADSM testing write up.pdf

While he has left us plenty to work off of (👍 ) he did get a few things wrong. First off is the defualt install location. He first got the "error" in test 4, and continues to reference the problem long after that. What really happened is that on test 1 when he installed and ran the program as expected, he setup the workspace in the default location with "Sample Scenario" active. Because he was not deleting the default workspace between installations, whenever it DID install correctly he was using that same workspace. (I'm not sure that explination made complete sense - I'm just trying to say that "error 4" is NOT an error and is doing exactly what we want it to).

He managed to catch 4 real errors however (tests 3, 5, 8, and 9). The good news here is that he caught the same error Missy posted on Nov 12 (Access is denied: 'PATH') (test 8). The other good news is that he found 3 errors we haven't seen before that should - better to catch them now and fix them before someone in the field does! The only problem I see with those is that we have no error message for test 9, I asked for clarification on what he meant by 'windows file' and he said "Installed it right in C:\Windows".

@missyschoenbaum I told him you would be more than happy to send a gift card but he politely declined and instead says he would like something to put on his resume - do you think you could write him up a nice line? Doesn't have to be too long but obviously he would like it to look pretty appealing to potential employers. Thanks!

[missyschoenbaum]

Wow. I haven't worked through the document yet, but here's bit for the resume.

Served as beta tester on the Animal Disease Spread Model application using an Agile methodology. Documented all test cases and reported bugs as needed.

[missyschoenbaum]

Fresh eyes are always nice!

[BryanHurst]

These are definitely some good test cases.

I can definitely see why installing on a flash drive would not work currently. @missyschoenbaum are portable installations something that we want to support (install on an external drive and take the program and workspace with you)?

I am concerned about the 5th test with the bad path, because the path string is definitely not a proper path. But if paths are being generated on the fly, that shouldn't happen.

I'll think through these tests and figure out what needs new issues created.

[missyschoenbaum]

@BryanHurst I had never really thought about a portal installation. How big of a problem is that?

[BryanHurst]

It mostly depends on how the CEngine reacts to being on portable media. However, if the CEngine is happy, I'd probably spend about 6 hours getting the frontend to be happy with relative paths.
Doing that could be an approach that bypasses most permission issues on computers that are managed in a corporate environment.

[missyschoenbaum]

Would it also bypass international language problems?

[BryanHurst]

Unfortunately, no.

[missyschoenbaum]

Another question on this. Does it undo the work we have dome to make this work in a cloud?

[BryanHurst]

No, the Cloud work would still be in place.

[BryanHurst]

As for leaving already existing workspaces, I believe this is possible.

For actual installations (not beta releases), we can look at the settings.ini file in the install folder. If the path is '' or some other user defined string, then we look in the old docs location or the user defined location.
If the path is '.', then we use the new relative deploy stuff.

I'll need to see if this will work okay with how the CEngine handles supplemental files.

[BryanHurst]

Testing with the CEngine shows that it is happy to move around the system.
It just needs the full workspace path passed in whenever it runs.

[BryanHurst]

I'm considering a first startup procedure that asks the user if they want the workspace to be "portable" or in a static location.

This would require getting file system path information from the user which html can't do currently. Plus it conflicts with a possible web deployment in the future.

We might display a pure Python popup that asks the question. Tkinter doesn't package well, so we may need to find a light GUI alternative.
This shouldn't be a big task. Just a bit of research.

[BryanHurst]

Two things remaining:

• [x] Modify the NPU to never upload a workspace folder or workspace.ini file (how to make this generic?)
• [x] Add an indicator button in the file select panel to display current workspace folder. Add button to delete workspace.ini and re-prompt.

[BryanHurst]

@missyschoenbaum When you update today, the NPU program will get an update as well.

Once updated, read through the workspace prompts when launching the program and let me know if we need to make any wording changes.

[missyschoenbaum]

@BryanHurst Can do!

[missyschoenbaum]

Looked OK to me. Everything seems to be working, but I didn't try a remote install.

[missyschoenbaum]

Missy try remote install

[missyschoenbaum]

@ConradSelig , would your friend be willing to try a remote install?

[ConradSelig]

I'll reach out and see if he has the time - I know he is quite busy this semester however, so no promises.

[missyschoenbaum]

Thanks, hopefully we wouldn't need the same type of extensive write-up that he did the first time. However, that write up was certainly excellent and something he could show as an example of his work.

[missyschoenbaum]

I tried just changing workspaces. I get a complete clean build, with my 2 sample scenarios. If I open Sample Scenario with Outputs, them attempt to view results, I get this. It makes perfect sense to me why this happens. Could we put an informational message before the copy happens that tells users they are leaving behind their results?

[missyschoenbaum]

Next I am going to test what happens to my old folder when I move things back. My guess is that it will wipe things out.

[missyschoenbaum]

Did not wipe things out. Perfect!