Can't Close Input Panels

[BryanHurst]

When creating new models (on any input page), the second and third panels open up. If you push cancel or back, they never fully close. Especially when using an input field that creates new functions (like on Vaccination Global).
This is an issue because sometimes these panels cover an apply or cancel button back on the main form.

[missyschoenbaum]

Mine does stay out, but will go back in if I use the back button.

[BryanHurst]

@BryanHurst can this be reproduced with a screenshot?

[ConradSelig]

I cant get this to be reproduced, maybe some screenshots would be helpful.

This may have also been fixed by commit c325877 (#919)

[BryanHurst]

I finally remembered to go back and look at this one, and it is still an issue.

This is a half closed center panel after pushing cancel:

On the same page, after pushing cancel on right panel, and then cancel on center panel:

This is a right panel after pushing cancel:

[missyschoenbaum]

Do we need to check this on Destruction Global also? Or just wait for the fix and see if all things resolve?

[BryanHurst]

This looks like it is an issue with the panel code and not specific to any page.

[ConradSelig]

@BryanHurst Is the right panel supposed to close after the user pushes cancel? Right now it looks like it brings the user back to the function overview screen - I believe that is working as intended. The right panel can also be closed by pressing its respective icon on the right toolbar.

I see the problem with the center panel, I've got a fix for it I just want to wait for confirmation on any possible right-panel changes before pushing.

[BryanHurst]

This one is probably a tricky UX decision.

I feel that if you open the right panel from the right nav, going back to the overview when pushing cancel is correct.

But if the user got to that panel by going through creation steps from another form, it makes sense to completely close when pushing cancel.

I did finally realize that you could close the right panel with the right nav, but it took me WAY too long to figure that out since I hadn't gotten to that screen through the right nav panel.

It either needs to be more obvious that this panel is coming from the right nav, or have a close button somewhere.

[ConradSelig]

I think keeping track of where it opened from and then closing it from the same location would be very difficult. Looking at it right now it seems that when a right-panel window is opened from somewhere NOT the right toolbar you have to press the corresponding right toolbar button twice to get the panel to disappear - meaning the toolbar is not being activated. I think due to the way that the right-panel normally works I would prefer to "activate" the right toolbar so panels can be easily closed from there instead of trying to get panels to close from somewhere else in the program.

[BryanHurst]

Yeah, I think having the proper nav item activate would be nice. It would give a visual clue to the user as to where they need to click to get out of it.

[ConradSelig]

Are any right-panel items opened from the page instead of the toolbar other than the population panel? I can't seem to find any instances where the population panel is not the one being opened.

[BryanHurst]

As best I can remember, that is the only panel.

On Wed, May 15, 2019 at 10:08 AM Conrad Selig notifications@github.com wrote:

Are any right-panel items opened from the page instead of the toolbar other than the population panel? I can't seem to find any instances where the population panel is not the one being opened.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NAVADMC/ADSM/issues/922?email_source=notifications&email_token=AAJAWBNUGJGKNIOWCQIAZCDPVQYPXA5CNFSM4GW27CB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVPE36I#issuecomment-492719609, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJAWBIWMPU6B3MVKUXWEATPVQYPXANCNFSM4GW27CBQ .

[ConradSelig]

When the functions panel is pulled out by a selector widget (like "Vaccination capacity" or "Restart vaccination capacity" on the Vaccination Global page) the right-toolbar is not activated. Moving back to development pipelines until this is fixed.

[BryanHurst]

Okay, this makes a little more sense user side now. It still isn't the "best" workflow, but getting it implemented in another way would be a large task.

[missyschoenbaum]

@ConradSelig I'm not sure of the action I am expecting. I can get the middle screen to cancel, and then I still have to close the right screen from the right panel. That is OK to me, because I am accustom to working with the right panel. Is that the expected action, or was there another. I don't follow from the notes above.

[missyschoenbaum]

OK, calling this one good.

[ConradSelig]

I am encountering a bug similar enough to this I'm re-opening the ticket.

Steps to recreate.

1. Open the "Disease Progression" page.
2. DON'T open any of the progressions inside.
3. Open the functions panel.
4. Select a relational function.

As you can see the center-panel's outline is drawn but remains empty. Clearly the function's panel expects it to be open so likely some functionality got crossed over. This should be a fairly easy fix.

[ConradSelig]

Another instance of this ticket spotted!

Steps to recreate:

1. Open the "Disease Spread" page.
2. Open up a disease spread.
3. Delete the same disease spread currently open by pressing the "x" icon.

Center panel outline is still shown. Just like last time this should be an easy fix - moving back to development pipelines.

[missyschoenbaum]

Looks good!