search

NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.
Other
10 stars 5 forks source link

Migrating ControlMasterPlan to VaccinationGlobal #933

Closed ConradSelig closed 5 years ago

ConradSelig commented 5 years ago

ControlMasterPlan is a model in ADSM that holds all of the fields for the Vaccination Global page - it would make more sense to call it VaccinationGlobal, and use it to validate the Vaccination Global page instead of using VaccinationRingRule for validation.

missyschoenbaum commented 5 years ago

Actually, holding that name that the top of the Control plan is somewhat odd. I am not sure people are going to get it, since there is just one name. I am not sure why it migrated from the old database. Can we default a value it in, like "Control Plan" and then rename as you suggest?

ConradSelig commented 5 years ago

Is this Control Plan variable just a placeholder value? I guess I'm not sure why that would be useful - or what kind of value you would want in there.

missyschoenbaum commented 5 years ago

Here's the history. In the old version, only functions had names. If you looked opened a model and looked at parameters, you would have no idea if someone was modeling FMD or cat scratch fever. ADSM rolled out the concept of named parameter blocks. Somehow, this high level section gets a named block, but I am not really sure why. I guess you could do one model and call the control plan "No vaccination" and another one and call it "Vaccinate Dairy Only". This requires that you have a big picture view and are thinking about many variations of your scenario, which a new user may not be to that point. However, it seems hidden on that Control Screen now that we have removed all the other global parameters. But, it is a required field. That's why I think could pass a default value, users can update if they catch on to the purpose, but it doesn't hang us up.

ConradSelig commented 5 years ago

OK sounds like I should make it a blank TextField so users can inject any data they want into it.

This should be a fairly easy ticket, so I'll get it worked out sometime soon.

ConradSelig commented 5 years ago

I had a little trouble getting things to cooperate with VCS but this seems to be working now - moving to testing.

missyschoenbaum commented 5 years ago

Is it possible that this error is related to this? No_Such_Table

BryanHurst commented 5 years ago

Yes, we realized in the meeting this morning that changes need to be made to the CEngine to reflect this change.

ConradSelig commented 5 years ago

Error still persists, but not does not tell the user what is wrong. I have no leads on what to do to fix this. I cannot even seem to find any solid links between the C Engine and the front end to trace back what the exit code means. (code is 3221225781).

@BryanHurst Can you advise on this?

BryanHurst commented 5 years ago

The error codes from the CEngine have no meaning. I'll look into the current state of things.

BryanHurst commented 5 years ago

@ConradSelig you currently getting no error because the newly compiled CEngine doesn't run at all. I'll push a new compile and we can look into your compile environment later.

missyschoenbaum commented 5 years ago

I'm not sure what I as testing here since you opened ticket. Do I need to check that something changes names in the database? Or, it is OK for you to close your own tickets if they pass what you expect.