Validation and Visual bugs with the Controls Page

[ConradSelig]

Controls can be turned on and off by toggling the slider on the "Controls" tab in the left-toolbar. This "Controls" page simply holds the name for the global controls section, however there are some interesting connections that are actually visible on the front end that I think we should be concerned with as they may be misleading to users. Here are four things I've noticed (and an annotated screenshot so it's easier to see what I'm describing)

A) Title of the Controls page is "Edit the Vaccination Global" which is not only poor grammar but the Controls section also contains destruction and zone settings. B) Sample Scenarios controls name is "High Vaccination Capacity" which is also a relational function even though they are not connected in any way. C) When the controls page is open is visual appears as if the Vaccination Global page is open as well - this works vice versa D) You can't really see it in the screenshot, but these validation markers are tracking the same thing. When the Vaccination Global page is filled out the Controls validation marker will also turn green - even if none of the other controls are validated. The Controls marker should turn green when ALL the controls pages are valid.

If this is still confusing we should plan to talk about it at Tuesdays meeting and leave a note here that is more flushed-out.

[missyschoenbaum]

Maybe this explains why the wording is bad. Production Controls page looks like this. It was updated to discuss how parameters are broken out. The name = High Vaccination Capacity is actually held in the database as an example name of a Control Plan. To change this, we would have to change the sample database build script.

[missyschoenbaum]

Here's an image, the vaccination global isn't appearing open in Prod.

[ConradSelig]

WOW - I have learned a LOT about how front-end pages are rendered during the process of this ticket. On top of that, I've cleared up a lot of the issues we were looking to fix up when we set out to migrate ControlMasterPlan to VaccinationGlobal (#933).

Here is a brief overview of the changes made:

• ControlMasterPlan is back! Now it stores the name for the control plan. (previously it was stored with the vaccination global data).
• No longer do we have a VaccinationMasterForm and a VaccinationGlobalForm. VaccinationGlobalForm was removed and was replaced with ControlMasterPlanForm, which actually does the same thing.
• The controls page no longer has a VaccinationGlobal url, now it has a ControlMasterPlan url.
• The controls page currently has no validation. The page will always be marked green due to defaults in the database that prevent it from ever being invalid. If we want to do full controls validation later a new ticket should be issued for that enhancement.
• Many other small code changes to support the above changes, all of which can be found in commit ecf3e33 (first commit above) .

[missyschoenbaum]

I think we are OK with no validation on Control Plan. We love it when you learn lots of stuff.

[ConradSelig]

The bugs introduced in this ticket were a result of #933.

[missyschoenbaum]

Got my Controls page, think we are good here.