search

NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.
Other
10 stars 5 forks source link

Graph previews are not consistent for functions that have been edited. #939

Closed ConradSelig closed 4 years ago

ConradSelig commented 5 years ago

Steps to recreate:

Create the following relational function: image.png

Edit the function to include the additional two points, note how the graph has updated as expected: image.png

Hit "back" and the re-open the function, note how no graph is showing (and the scale does not match expected): image.png

Note: pressing "edit" -> "overwrite" -> "apply" (without changing ANY settings) shows the expected graph again.

@missyschoenbaum if you could confirm these steps that would be great - I saw some other strange actions while discovering this bug but cannot seem to methodically re-create.

missyschoenbaum commented 5 years ago

Can do.

missyschoenbaum commented 5 years ago

Based on Neil's words in #183, maybe these shouldn't have a straight line? Never mind, that doesn't matter here.

missyschoenbaum commented 5 years ago

I ran through steps to repeat as listed above. I didn't have same problem. I do have quirks sometimes, but like you said, often hard to recreate.

ConradSelig commented 5 years ago

I'm going to move to backlog then. Clearly some more testing needs to be done to determine actual graph behavior.

ConradSelig commented 5 years ago

I've now spent about 2 hours clicking around the program, stepping through the code in debug mode, even trying different browsers... I've got nothing new. I can replicate my bug described above, but I can't figure out where the blank graph is coming from - or why Missy is getting different results from the same steps.

My best idea is that the graph is not loading properly, maybe something about the rest of the form loading faster than the graph can be made? This might default the graph out to a "default" unit graph, but I don't know why this would happen some times but not other times.

ConradSelig commented 4 years ago

I have determined that graphs are being created properly and are just not loading as expected, I think it may have also something to do with cached images - because sometimes an out-of-date version of the graph is shown when applying an overwrite. I'll keep working on this.

BryanHurst commented 4 years ago

@ConradSelig are there any other places that could benefit from cache busting in the url like this?

ConradSelig commented 4 years ago

hmmm interesting question, I'll poke around the templates and see if there are any other places I can apply a similar change. See #982

missyschoenbaum commented 4 years ago

@ConradSelig , so I just need to run it through paces and see if I can identify anything else?

ConradSelig commented 4 years ago

@missyschoenbaum That's correct. Your looking to any action that gives you graph previews that do not match the data. Make sure you have some steps to reproduce if you run into anything.

missyschoenbaum commented 4 years ago

It didn't do anything weird for me. Let's call it good and revisit if we have a future problem