Fix workspace folder issues.

NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.

Other

10 stars 5 forks source link

Fix workspace folder issues. #943

Closed ConradSelig closed 4 years ago

ConradSelig commented 5 years ago

With the newest changes in #760, #910, and #73 a scenario's workspace folder can get quite cluttered with lots of files! Do we want to put all of these new export/output files into a new nested folder titled "Exports and Other Outputs"?

This is seriously a 5 minute fix, and may help users differentiate between the scenario itself, the formal outputs, the supplemental outputs, and other exports/outputs. I've included a screenshot of a scenario folder with outputs from all 3 of the above tickets for "clutter" reference:

ConradSelig commented 5 years ago

Some folders are being created in the workspace folder directly without files in them. This includes folders such as "Supplemental Output Files" and "Combined Outputs".

Bryan also reports the map outputs being put next to the map folder but not in it.

In summary:

[x] Exported folder should be placed in an embedded folder "Exported Files".
[x] Folders "Supplemental output files" and "Combined Outputs" are being placed in the workspace folder.
[x] Map outputs are not being put in the map folder.

ConradSelig commented 5 years ago

I deleting the "Supplemental output files" and "Combined Outputs" folders in my base workspace folder and have been unable to recreate them through ADSM.

@missyschoenbaum @BryanHurst Could you two also delete these folders and keep an eye on your workspace folders? I don't see anywhere in the code where they are actively being created, so perhaps they were being created somewhere in the distant past and have been sitting around since. On the flip-side, if we can figure out where in the program they are being created we can patch the bug.

Thank you both!

missyschoenbaum commented 5 years ago

Can do.

BryanHurst commented 5 years ago

I'm still seeing them created in the base workspace folder.

Here is my clean folder:

This is my folder during initial app startup (the first page hasn't even loaded yet, we are still going through migrations):

missyschoenbaum commented 5 years ago

Can we keep this names as just "Exports".

ConradSelig commented 5 years ago

@BryanHurst I see you have a "Map" folder in there as well, Is that one intentionally placed there or has it been created by ADSM as well?

ConradSelig commented 5 years ago

Found where the folders were being created. The "Map" folder is not being created for me, so I'm assuming it's intentional.

Still got one bug regarding the map's save location, so this ticket will still be in Dev.

ConradSelig commented 5 years ago

Fun fact! In some cases the population maps being created outside the Map folder and the supplemental outputs/combined outputs folders being created in the base workspace folder was actually the same problem!

Has absolutely no impact on testing to know this, but it's fun to think about.

BryanHurst commented 5 years ago

That extra Map folder that you asked about was not intentional and is continually being created.

ConradSelig commented 5 years ago

I have more code to add then, moving out of testing.

ConradSelig commented 5 years ago

Bryan recommended that we have a global exports folder system in the base workspace folder. This way exports are not located in a large range of places.

Split folders into "Exported Functions", "Exported Populations", etc.

missyschoenbaum commented 5 years ago

I'm not seeing an export folder. I get fails on the export tickets. I will post code over there (both pop and functions).

missyschoenbaum commented 4 years ago

Referring to #73 on the failing export ticket. Updated info in that ticket.

missyschoenbaum commented 4 years ago

This worked.

missyschoenbaum commented 4 years ago

Got a folder this time. Calling it good.