search

NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.
Other
10 stars 5 forks source link

New build - All Panels except SQL are disabled #959

Closed missyschoenbaum closed 5 years ago

missyschoenbaum commented 5 years ago

Note, I confirmed that Sample Scenario was not my open scenario, then I deleted it due to #958 before I ran npu and opened app. Steps to repeat: Open application click on project panel - no response, no action in CMD click on settings panel no response, no action in CMD click on population panel - no response, no action in CMD click on function panel - no response, no action in CMD click on documentation panel - no response, no action in CMD click on SQL panel, SQL window opens, and allows me to return.

ConradSelig commented 5 years ago

Right-panel items are disabled, and center-panel items are also not working properly. Open up any form that is located in the center-panel (like disease progression for example) and the form shows as full-screen, completely un-stylized, and the "cancel" button does not bring the user back to menu.

Obviously something big has changed with the 3 panel system since the last build. This could take awhile to track down, and is worsened by the fact that to program seems to be working just fine on the developer side. That means that this could be a viewer issue - which would be much worse than any possible kind of linking or styling error.

Looks like it's going to be a long day, I'll make another comment here when I find something of interest.

ConradSelig commented 5 years ago

@BryanHurst What can you tell me about the Viewer application? I can't gleam anything from the .dll or .pak files.

Did the ADSM team write it? If so, where is the source code? If not, where did the code come from?

There have not been any changes to the entire Viewer directory since 2015, so I doubt the problems presented here are viewer related - yet the fact stands that the application works just fine in development but not in deployment, and the only difference there is the viewer.

BryanHurst commented 5 years ago

The Viewer is Google's Chromium with one modification to automatically load a specific local page on startup.

I'll jump in on this issue and see what I can find this morning.

BryanHurst commented 5 years ago

When running the build and pointing a normal browser to the server port, the issue does not exist, so this is specifically in Viewer.

I have an odd hunch that may not lead to anything. Can either of you confirm if your Windows system recently updated to version 1903 (You can check in the Update History).
If so, I'd like to try and find a system that hasn't yet updated to 1903 and try the latest build on it.

ConradSelig commented 5 years ago

Do you mean update version 1803? Ie update "KB4512501" or OS Build 17134.950

missyschoenbaum commented 5 years ago

Here's what mine looks like: UpdateHistory_Missy

missyschoenbaum commented 5 years ago

I think that means no 1903 yet.

ConradSelig commented 5 years ago

1703 interesting... your last update was almost a month ago. I got 1803 yesterday.

My laptop is also on 1803, so no luck there.

missyschoenbaum commented 5 years ago

Yes, my updates are tightly controlled by IT and I have no way to dictate what happens and when. We mainly update when there is a security flaw that needs to be patched.

missyschoenbaum commented 5 years ago

Also, we don't tend to be the bleeding edge. Someone tries it first and makes sure it does't take down any internal system.

ConradSelig commented 5 years ago

I might be able get 1809 on my laptop, @BryanHurst do you want me to try that?

BryanHurst commented 5 years ago

Well, like I said that probably wouldn't lead to anything. Since there is a 1803 and 1703 we are having the same issue on, this isn't the right path.
I had a few other projects that 1903 broke because of some cryptographic library updates.

I'll keep hunting on this end.

BryanHurst commented 5 years ago

Okay, I found it.

@ConradSelig there is a javascript error on line 1017 of adsm.js.

It works in our "modern" version of Chrome when in development, but that line crashes in the older version of Chromium.

I'm pushing a patch now.

missyschoenbaum commented 5 years ago

Yeah team! That worked. Do we need to keep this ticket open to discuss how to keep this from happening in the future?

BryanHurst commented 5 years ago

The best way to approach this is to write javascript like you are using IE 11 (just to be safe).
So no new api functions or new syntax.

For the future, it would be good to update our Viewer to the latest Chromium library. That would be a day or two worth of work in C.
I was the one who originally did that Viewer work and could do it again, or it could be a good C learning project for Conrad.

missyschoenbaum commented 5 years ago

Can you make a new ticket for it? Doesn't matter to me who works on it.

BryanHurst commented 5 years ago

961 will tackle the Viewer issues.

missyschoenbaum commented 5 years ago

OK, this is working.