search

NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.
Other
10 stars 5 forks source link

Update Viewer Application #961

Closed BryanHurst closed 4 years ago

BryanHurst commented 5 years ago

The Viewer application has fallen behind the Chromium project and needs some updating for security reasons and to be able to support modern javascript and css.

While working on it, we can also look into better handling for #898.

BryanHurst commented 5 years ago

Look into #805 at the same time.

BryanHurst commented 5 years ago

This may also fix the issue where you can't launch any side menus after upgrading Jinja2 to the latest security patch.

ConradSelig commented 5 years ago

This may also fix some of the pop-up window issues like in #941

BryanHurst commented 4 years ago

Unfortunately cefbuilds.com which was maintained by Adobe has been retired.

This removes our fast route to integrating Chromium updates to our Viewer application.

BryanHurst commented 4 years ago

Moving forward, I've started a completely new desktop application in C# that will use an embedded CEF widget.

This will give us a fast route for upgrading the Chromium library in the future, but will take a bit more effort here at the start.
It will also give us more control over the interface and user interactions.

BryanHurst commented 4 years ago

After a couple of hours, I'm about half way done with this now.

I'll get it done after another day of work on it.

The total time spent will have been pretty small.

BryanHurst commented 4 years ago

@missyschoenbaum and @ConradSelig this will need to have a thorough testing of all application features to ensure the new Viewer doesn't break any JavaScript functions or CSS rendering.

BryanHurst commented 4 years ago

NOTE: The new libcef.dll file is 107MB which is larger than GitHub's max file size of 100MB.
To accommodate this, the file is committed with Git LFS. Make sure you have this Git extension installed before pulling.

missyschoenbaum commented 4 years ago

I think this is working, but not sure how to test rigorously.

BryanHurst commented 4 years ago

Mostly we just need to confirm that the Viewer opens and doesn't throw any sort of admin/permission errors.

If you are running the program, things are probably good.