search

NAVADMC / ADSM

A simulation of disease spread in livestock populations. Includes detection and containment simulation.
Other
10 stars 5 forks source link

Trace Reasons - not seeing options #990

Closed missyschoenbaum closed 4 years ago

missyschoenbaum commented 4 years ago

Note - there is a way to work around this that may give a clue to what is happening

In Control Protocols - Destruction. When I use Trace forward indirect, I get an error. Checked and I also get error on Trace Back Direct and Trace back indirect. We had this problem before, but don't think this is the same.

This validation is connected to destruction reason order list, recall it would fail if it was missing one of these parameters .

Work around - when I go to the Destruction Global tab and rearrange the secondary destruction priority (in any order), apply. Then the scenario will validate.TraceReasons.PNG

missyschoenbaum commented 4 years ago

Maybe this is related to #858 or #855

missyschoenbaum commented 4 years ago

Steps to recreate: Open Sample Scenario, save as new name Go to Control Protocol, Destruction Select a trace to destroy, (Destroy indirect forward traces, Destroy direct back traces, or Destroy indirect back traces - the first one Destroy direct forward traces works) apply whichever one you choose. validate scenario Error message happens

Now, if I go over to Destruction Global, rearrange the secondary priority and save, the scenario will validate and run.

ConradSelig commented 4 years ago

I recall it was a fight to get the destruction widget working in the first place - but I'm sure this can be fixed.

I'll take this one.

ConradSelig commented 4 years ago

Looks like I got to reuse some code I wrote, for this exact reason!

I also know why this error occurred, I can share in our next meeting if either of you in the next meeting if you are interested.

Otherwise this bug should be fixed - honestly I'm surprised it did not come up sooner.

missyschoenbaum commented 4 years ago

Dir Back tested, OK Ind Fwd tested OK, ind back tested OK, Dir fwd tested - OK.

All test cases pass