NAXAM / googleima-ios-binding

Xamarin Android Library - Google IMA
MIT License
0 stars 2 forks source link

Incorrect definition in nuget #1

Open Wenfengcheng opened 5 years ago

Wenfengcheng commented 5 years ago

@tuyen-vuduc I try to install Naxam.GoogleIMA.iOS into my project. But when I use it, I found that some of the classes are incorrectly defined.

E.g Here is the definition in nuget:

    [Register("IMAAVPlayerContentPlayhead", true)]
    public class IMAAVPlayerContentPlayhead : NSObject, IIMAContentPlayhead, INativeObject, IDisposable
    {
        [CompilerGenerated]
        [Export("initWithAVPlayer:")]
        public IMAAVPlayerContentPlayhead(AVPlayer player);
        [CompilerGenerated]
        [EditorBrowsable(EditorBrowsableState.Advanced)]
        protected IMAAVPlayerContentPlayhead(NSObjectFlag t);
        [CompilerGenerated]
        [EditorBrowsable(EditorBrowsableState.Advanced)]
        protected internal IMAAVPlayerContentPlayhead(IntPtr handle);

        public override IntPtr ClassHandle { get; }
        [CompilerGenerated]
        public virtual double CurrentTime { get; }
        [CompilerGenerated]
        public virtual AVPlayer Player { get; }
    }

But different from the definition in the Apidefinition.cs file which is the correct definition. IMAAVPlayerContentPlayhead should integrate the abstract class IMAContentPlayhead instead of inheriting the interface of IIMAContentPlayhead.

Perhaps you use the wrong Apidefinition file in the framework folder when you created the nuget. Please update this nuget and release new version.

Best, Wenfeng

Wenfengcheng commented 5 years ago

@tuyen-vuduc

I am very sorry that you can't reply to my issue and #2 , I have forked and modified your repo, and re-released a nuget. Maybe we can maintain the entire project together.