NAXAM / stripe-ios-binding

Xamarin Binding Library - Stripe iOS SDK
MIT License
12 stars 13 forks source link

All architectures binary must be provided. #1

Closed xplatsolutions closed 7 years ago

xplatsolutions commented 7 years ago

Thank you for your work :-)

I guess you didn't try it with the Simulator, but how are you handling the different architectures? The solution is to build a fat binary for all architectures, see in my repo here, https://github.com/xplatsolutions/Stripe-Xamarin-iOS-Bindings/tree/master/FromSource.

The ideal would be to have one library for simulator and one for device and change using a build script or with your CI-CD platform.

Let me know how would you prefer to tackle this.

P.S. I think it's better to build two framework and not carry the static library binary only because I noticed resources will be missing, I will add the frameworks in my repo if you want or let me know how we can connect, my email is taskos.george@gmail.com :-)

tuyen-vuduc commented 7 years ago

You are right!

The provided framework from the pod isn't that fat (I built the binding using Sharpie POD).

We will need to build a really fat framework from source.

You could reach me at tuyen@naxam.net.

tuyen-vuduc commented 7 years ago

Commit 026a36643faed59874b66d5f3c93d8cbef4c20fa