Closed tsalo closed 6 years ago
For tissue type we just need the masks, so extracting the data shouldn't be difficult once we're working with real data. I just need to make sure I can add it to the plots without messing them up.
It seems that for this subject, the y-range is a little too wide, but if there are high-motion subjects or if we want the same y-range across all, then this is good. Might be nice to have a line on the FD plot for the FD_thresh? Otherwise, it looks great!
Katie
On Jul 5, 2018, 12:45 PM -0400, Taylor Salo notifications@github.com, wrote:
Also, we need to fix the right side's y-axis label ("FD\n(mm)") so that it's not encroaching on the plot. @emdupre @62442katieb Do you see any other issues with the carpet plots? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
This is great, @tsalo ! :tada:
There's some code from MRIQC that deals with carpet plots for segmented tissue types— around L78 here. I suppose we could just use their function, too, if need be.
I copied and adapted the niworkflows functions for our purposes and the plots look pretty good now:
Tissue type is on the left. There's no GM/WM split, but I don't think we need it.
Also, we need to fix the right side's y-axis label ("FD\n(mm)") so that it's not encroaching on the plot.
@emdupre @62442katieb Do you see any other issues with the carpet plots?