Closed rabellamy closed 7 years ago
/me 👀
The rest looks good based on the updated Ansible version too. To me this looks 👍 but I am not in a position to test it right now (I'm step debugging on my local pubstack right now so I can't redo my local setup for a bit). I will try to do that soon, but if anyone else can test this in the meantime that would be great.
I think there are some smaller PRs that could be separated from this one - for instance, just changing the box is pretty self-contained.
We should also be somewhat careful about bumping versions of things, since the goal is to be exactly where Acquia Hosting is at.
@cweagans True. The other thing is NBCU is moving everything off of Acquia LOL… but I agree we should keep version parity as long as we're supporting pubstack, since that's it's primary goal (I'll keep comments about whether or not to support it in #194 ).
FWIW, I patched Pubstack locally with this PR and it worked out just fine. Most importantly it resolved the fatal error posted in the description.
👍
Getting back to this, in the end we will almost definitely do #194, but as I just noted in https://github.com/NBCUTechnology/pubstack/issues/194#issuecomment-249311637 We will need to get some patternlab equivalent before we officially deprecate pubstack.
And right now there are some NBCU devs frontend who need to use this specifically for the patternlab directory inside their project repo. Because of that I want to merge this PR.
I agree with @cweagans that we could potentially split this apart, but for now this just gets our current pubstack to be able to actually install - and this may (possibly) be the last functional PR we every merge on the project. I'm no longer worried about Acquia parity / version bump though, because we're now off of Acquia hosting entirely.
The PPA that is being installed for
apache2
andibapache2-mod-fastcgi
has been updated and the minimum version for Ubuntu is currently 14.04 LTS (Trusty Tahr).Upgrading to 14.04 helped resolve this error:
I upgraded my local version of Ansible to 2.0.2.0 and received multiple warnings during provisioning like:
Updating the playbooks to use the full variable syntax mitigated these warnings.
@scottrigby, @cweagans, @ericduran and @conortm