NBCUTechnology / pubstack

⛔️ [DEPRECATED] Publisher's DevStack
MIT License
8 stars 8 forks source link

upgrades config.vm.box to 'ubuntu/trusty64' #193

Closed rabellamy closed 7 years ago

rabellamy commented 8 years ago

The PPA that is being installed for apache2 and ibapache2-mod-fastcgi has been updated and the minimum version for Ubuntu is currently 14.04 LTS (Trusty Tahr).

Upgrading to 14.04 helped resolve this error:

fatal: [dev]: FAILED! => {"cache_update_time": 0, "cache_updated": false, "changed": false, "failed": true, "msg": "'/usr/bin/apt-get -y -o \"Dpkg::Options::=--force-confdef\" -o \"Dpkg::Options::=--force-confold\"   install 'apache2'' failed: E: Unmet dependencies. Try 'apt-get -f install' with no packages (or specify a solution).\n", "stderr": "E: Unmet dependencies. Try 'apt-get -f install' with no packages (or specify a solution).\n", "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\nYou might want to run 'apt-get -f install' to correct these:\nThe following packages have unmet dependencies:\n libapache2-mod-fastcgi : Depends: apache2.2-common (>= 2.2.4) but it is not going to be installed\n", "stdout_lines": ["Reading package lists...", "Building dependency tree...", "Reading state information...", "You might want to run 'apt-get -f install' to correct these:", "The following packages have unmet dependencies:", " libapache2-mod-fastcgi : Depends: apache2.2-common (>= 2.2.4) but it is not going to be installed"]}

I upgraded my local version of Ansible to 2.0.2.0 and received multiple warnings during provisioning like:

[DEPRECATION WARNING]: Using bare variables is deprecated. Update your
playbooks so that the environment value uses the full variable syntax
('{{variable}}').
This feature will be removed in a future release.
Deprecation warnings can be disabled by setting deprecation_warnings=False in
ansible.cfg.

Updating the playbooks to use the full variable syntax mitigated these warnings.

@scottrigby, @cweagans, @ericduran and @conortm

scottrigby commented 8 years ago

/me 👀

scottrigby commented 8 years ago

The rest looks good based on the updated Ansible version too. To me this looks 👍 but I am not in a position to test it right now (I'm step debugging on my local pubstack right now so I can't redo my local setup for a bit). I will try to do that soon, but if anyone else can test this in the meantime that would be great.

cweagans commented 8 years ago

I think there are some smaller PRs that could be separated from this one - for instance, just changing the box is pretty self-contained.

We should also be somewhat careful about bumping versions of things, since the goal is to be exactly where Acquia Hosting is at.

scottrigby commented 8 years ago

@cweagans True. The other thing is NBCU is moving everything off of Acquia LOL… but I agree we should keep version parity as long as we're supporting pubstack, since that's it's primary goal (I'll keep comments about whether or not to support it in #194 ).

helior commented 8 years ago

FWIW, I patched Pubstack locally with this PR and it worked out just fine. Most importantly it resolved the fatal error posted in the description.

👍

scottrigby commented 7 years ago

Getting back to this, in the end we will almost definitely do #194, but as I just noted in https://github.com/NBCUTechnology/pubstack/issues/194#issuecomment-249311637 We will need to get some patternlab equivalent before we officially deprecate pubstack.

And right now there are some NBCU devs frontend who need to use this specifically for the patternlab directory inside their project repo. Because of that I want to merge this PR.

I agree with @cweagans that we could potentially split this apart, but for now this just gets our current pubstack to be able to actually install - and this may (possibly) be the last functional PR we every merge on the project. I'm no longer worried about Acquia parity / version bump though, because we're now off of Acquia hosting entirely.