search

NBISweden / IgDiscover-legacy

Analyze antibody repertoires and discover new V genes from high-throughput sequencing reads
https://www.igdiscover.se
MIT License
17 stars 10 forks source link

IgDiscover crashes if no arguments are given #110

Closed ressy closed 3 years ago

ressy commented 3 years ago

This is a very minor issue but I noticed in the latest stable version (0.12.3) that if no command-line arguments are given, the igdiscover command crashes before it reaches the expected error message.

$ igdiscover 
Traceback (most recent call last):
  File "/home/jesse/miniconda3/envs/example-igdiscover/bin/igdiscover", line 10, in <module>
    sys.exit(main())
  File "/home/jesse/miniconda3/envs/example-igdiscover/lib/python3.8/site-packages/igdiscover/__main__.py", line 85, in main
    del args.func
AttributeError: func

I'm thinking the del args.func here should probably be conditional on the value of subcommand, so you get the 'Please provide the name of a subcommand to run' message a few lines below?

marcelm commented 3 years ago

Thanks, you are right! That should be fixed now.