NBISweden / LocalEGA

Please go to to https://github.com/EGA-archive/LocalEGA instead
Apache License 2.0
4 stars 1 forks source link

Remove nc and curl from mq entrypoint and use rabbitmq utilities #328

Closed blankdots closed 6 years ago

blankdots commented 6 years ago

As the title presents itself. No need for nc and curl packages in MQ entrypoint.

Why we did this?

Not to have dependencies for those packages. We had this anyway for Kubernetes and decided to bring it to the main bootstrap.

Is this really a PR for just one file?

Good observation skills. Unless there is something more, that will be it :)

Icing on the :cake:

blankdots commented 6 years ago

Rabbitmqadmin is added because we use the management image from RabbitMQ so yes it is always available and rabbitmqctl is added in the base image

silverdaz commented 6 years ago

ok, great.