NBISweden / LocalEGA

Please go to to https://github.com/EGA-archive/LocalEGA instead
Apache License 2.0
4 stars 1 forks source link

Improve image base and CI build #358

Closed blankdots closed 6 years ago

blankdots commented 6 years ago

Separate the OS (packages + python install) from actual source code in order to streamline build based on an idea by @silverdaz, an effort to improve: https://github.com/NBISweden/LocalEGA/pull/348 Part of this PR:

Do we need to make changes to deployment options?

No. Image names and configuration stayed the same.

How to test this?

As it stands check the extras/travis.sh and after merge we should do two additional PRs one with a images/os/Dockerfile change and one without.

Would be nice of the rabbitmq version got bumped.

Yes indeed, but there was a bug https://github.com/NBISweden/LocalEGA/issues/225 and we fixed the version. In the meantime rabbitmq 3.7 changed their configuration formatting: http://www.rabbitmq.com/blog/2018/02/22/new-configuration-format-in-rabbitmq-3-7/ . If enough interest and depending on CEGA version we might change it. Mostly because of security updates.

One integration test fails.

We should increase travis sleep, run again that job or be smart about it and modify the integration tests and make it wait for services to be up.