Update gh-collaboration.qmd

NBISweden / Training-Tech-shorts

Short lessons, training various technologies useful to our work.

https://nbisweden.github.io/Training-Tech-shorts/

3 stars 11 forks source link

Update gh-collaboration.qmd #16

Closed mahesh-panchal closed 3 months ago

mahesh-panchal commented 4 months ago

Assignees:

[x] Making a branch - Tomas, review: Martin
[x] Making changes - Cormac, review: Guilherme
[x] Making a draft pull request - Per, review: Verena
[x] Making a ready for review pull request - Miguel, review: Tomas
[x] Code review - Martin, review: Cormac
[x] Merging - Verena, review: Miguel

mahesh-panchal commented 4 months ago

I definitely messed up in instruction here. I was supposed to review the additions before they get merged back into this branch. There's supposed to be one review from your review partner while in draft mode, and then another from the teacher when it's ready for review. Teacher does the merging into the branch.

RedondoMA commented 4 months ago

Sorry, Mahesh! I got it now. I thought you would review it only before merging to the main branch! Good that we had this first introductory lesson :)

mahesh-panchal commented 4 months ago

It's good to do this so we know what's working and what's not. I also forgot to include how to go over responding to review comment suggestions. I can see if branch rules can help, but it seems a review lesson would be a good thing to do soon.

mahesh-panchal commented 4 months ago

Perhaps following weeks should be the review lesson, so we do one lesson, review lesson, another lesson, review lesson