NBISweden / encam

Encyclopedia of Cancer Microenvironment
http://encima.one
2 stars 2 forks source link

Refactor plotting code #24

Closed danr closed 4 years ago

danr commented 4 years ago

It appears to be viable to do all plots using vega-lite, this is being investigated in the branch vega-lite branch. This would remove the hairy d3 soup that makes the plots right now.

danr commented 4 years ago

This has been done and had to be done twice:

  1. Vega-lite seemed promising and although it was possible to express the plots rendering is a bit too slow and hard to customize. However the plots could come useful for exporting or the knowledge for making the second page analysis in a later stage in the project.
  2. The plots were drawn using the DOM. This is a bit more manual work but in the end turned out to be easier and more convenient than d3 and easier to customise. :+1: