search

NBISweden / sda-cli

User command line interface for the SDA
GNU Affero General Public License v3.0
5 stars 1 forks source link

Feature/download fileid #417

Closed kostas-kou closed 3 months ago

kostas-kou commented 3 months ago

Related issue(s) and PR(s)
This PR closes #414.

Description It was implemented in the sda_download that the user can download files by providing the file id. This PR:

How to test Spin up containers by running:

bash .github/integration/setup/setup.sh

and then run:

./sda-cli sda-download -config testing/s3cmd-download.conf -dataset-id https://doi.example/ty009.sfrrss/600.45asasga -url http://localhost:8080 -outdir download-fileid urn:neic:001-001

and you should see the file in the download-fileid/main/subfolder/dummy_data path

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.60%. Comparing base (93e406c) to head (533cdcf).

Files Patch % Lines
sda_download/sda_download.go 83.33% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #417 +/- ## ======================================= Coverage 41.60% 41.60% ======================================= Files 13 13 Lines 2024 2024 ======================================= Hits 842 842 Misses 1063 1063 Partials 119 119 ``` | [Flag](https://app.codecov.io/gh/NBISweden/sda-cli/pull/417/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NBISweden/sda-cli/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | `41.60% <83.33%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.