codecov-commenter
commented
3 months ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 43.10954% with 161 lines in your changes missing coverage. Please review.
Project coverage is 39.29%. Comparing base (
69e2752) to head (4faf382).
| Files | Patch % | Lines |
|---|---|---|
| download/download.go | 43.72% | 139 Missing and 18 partials :warning: |
| list/list.go | 0.00% | 2 Missing :warning: |
| main.go | 0.00% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #427 +/- ## ========================================== - Coverage 41.24% 39.29% -1.96% ========================================== Files 13 11 -2 Lines 2051 1891 -160 ========================================== - Hits 846 743 -103 + Misses 1084 1036 -48 + Partials 121 112 -9 ``` | [Flag](https://app.codecov.io/gh/NBISweden/sda-cli/pull/427/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NBISweden/sda-cli/pull/427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | `39.29% <43.10%> (-1.96%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Related issue(s) and PR(s)
This PR closes #398 .
Description
download(eg./sda-cli download <urls_file>) is deprecated and removed./sda-cli datasetsize <urls_file>) as it was dependent on the now deprecated function for downloading files withurls_file.sda-download(./sda-cli sda-download) renamed todownloadHow to test
./sda-cli download -config <configuration_file> -dataset-id <datasetID> -url <download-service-URL> <filepath>./sda-cli download -pubkey <public-key-file> -config <configuration_file> -dataset-id <datasetID> -url <download-service-url>