NBISweden / sda-cli

User command line interface for the SDA
GNU Affero General Public License v3.0
5 stars 1 forks source link

Feature/list dataset show more info #443

Closed MalinAhlberg closed 2 months ago

MalinAhlberg commented 2 months ago

Related issue(s) and PR(s)
This PR closes #433.

Description

How to test From the root folder run the setup script:

bash .github/integration/setup/setup.sh

(note to future self: if it does not work, remove all containers and run docker volume rm -f $(docker volume ls -f "dangling=true")). Then run:

./sda-cli list -config testing/s3cmd-download.conf -dataset https://doi.example/ty009.sfrrss/600.45asasga -url http://localhost:8080 

And get

FileID                   Size            Path
urn:neic:001-001     1.0 MB      5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8_elixir-europe.org/main/subfolder/dummy_data.c4gh
urn:neic:001-002     1.0 MB      5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8_elixir-europe.org/main/subfolder2/dummy_data2.c4gh
urn:neic:001-003     1.0 MB      5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8_elixir-europe.org/main/subfolder2/random/dummy_data3.c4gh
Dataset size: 3.1 MB
codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.04%. Comparing base (214bd0d) to head (d1a2b85). Report is 270 commits behind head on main.

Files with missing lines Patch % Lines
list/list.go 0.00% 11 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #443 +/- ## =========================================== - Coverage 52.66% 39.04% -13.62% =========================================== Files 9 11 +2 Lines 1183 1903 +720 =========================================== + Hits 623 743 +120 - Misses 481 1048 +567 - Partials 79 112 +33 ``` | [Flag](https://app.codecov.io/gh/NBISweden/sda-cli/pull/443/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NBISweden/sda-cli/pull/443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | `39.04% <0.00%> (-13.62%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MalinAhlberg commented 2 months ago

Looks good! Just a minor comment about the usage of single dash - or double dash -- in the usage description.

Thanks @nanjiangshu ! Fixed by d1a2b85, please resolve when happy.