Closed fasterius closed 1 week ago
Regarding existing GitHub Actions:
docker-run.yml
/ docker-build-and-run: This just tests that the Container tutorial image (Dockerfile
not Dockerfile_slim
) can be built and run. As this is the "final" image of the Container tutorial and not edited by the students it makes sense to keep this, but we might optimise it if we want.setup.yml
/ install: This attempts to install all Conda environments on both MacOS and Ubuntu. Good thing to test, but we should change the default fail-fast
matrix option to false
, as most jobs are currently being cancelled if a single job fails (which for this type of test we don't want). Some steps use outdated actions, which we should update. We should also filter for the relevant paths, so that the action doesn't run when none of its files have been changed.setup-slim.yml
/ docker-slim-install: This does the same as the above action, but inside the image created with the tutorials/containers/Dockerfile_slim
Dockerfile. I'm not sure why we do this. I have tried searching through the tutorials and the pre-course setup and find where this image is mentioned, but it just seems that it's the image the students starts with in the tutorial and add changes to. Did we use this before as well for Windows or something, before we required WSL2 for Windows students? Or am I missing something? Currently it seems we could remove this action. (If there is good reason to keep it the same issues as for the above action applies.)Did we use this before as well for Windows or something, before we required WSL2 for Windows students?
Yes that's exactly what it was for
Big PR here, with the overall changes required for moving to GitHub Pages using Roy's Specky template for Quarto. In summary:
tutorials/
andlectures/
directories and unchanged, except that HTML lectures are no longer directly stored in the main Git repository, but are accessed from the website itself.schedule.xlsx
Excel file in the repo root and will be formatted with cool code made by Roy.Some things still need to be done:
devel
conflictsMy proposal for this new system would be that we only keep the
main
branch and either remove/archive or ignore thedev
branch, which was only used for testing changes on Canvas. This is no longer necessary as new changes/contributions can be tested by building the website locally before opening a PR from a feature branch. We can keep tagging course rounds as we have done previously, which can be re-build locally if somebody wants to check out them, although experience leads me to believe that this is unlikely to be the case.This PR is against the
devel
branch to get a better diff against the latest changes, but as soon as this PR is approved we should also merge it directly intomain
.