search

NBP-ACC / week-5-acc_01

week-5-acc_01 created by GitHub Classroom
0 stars 0 forks source link

Group 3 #16

Open toludwig opened 5 years ago

toludwig commented 5 years ago
  1. 3/3. Very nice plot grid. Maybe instead of plt.subplots(...) you can try sns.FacetGrid().
  2. 5/5. Nicely separated preprocessing before checking hypotheses (we didn't dropna and had a positive slope in hyp 1). But as you say, the effect is to be taken with caution, the dots are very spread.
  3. 2/2. Nice sanity check of t/p-values with np.isclose().

2 points for good coding style. Very clean and legible and producing pretty, clean graphs. Well documented.

shrnkm commented 5 years ago

Hey,

thanks for the review and 'FacetGrid()' note. I'm trying to work with it now.