e2e test data cleanup relies on spotify ui

NBS-LLC / ng-spotify-importer

Import playlists into Spotify.

https://nickwanders.com/projects/ng-spotify-importer/

GNU General Public License v3.0

100 stars 17 forks source link

e2e test data cleanup relies on spotify ui #250

Open NBS-LLC opened 10 months ago

NBS-LLC commented 10 months ago

Spotify UI is subject to change without notice, breaking e2e test data cleanup code.

NBS-LLC commented 10 months ago

The current cleanup code makes use of Spotify's Web Player to login and remove playlists. This was done because of a misunderstanding of what "remove" actually does. The reality is that "remove" unfollows the playlist, which can be done via an API call. An API call is the preferred option because Spotify's public APIs are under version control and will not change without notice.

NBS-LLC commented 10 months ago

Currently-

The e2e test data (playlist names) are managed using the TestDataManager class. Playlist names are added to the manager after a test performs an import playlist action. Cleanup occurs in an after hook using a combination of the TestDataManager and Spotify's Web Player UI.