NC22 / KellyC-Show-YouTube-Dislikes

Shows dislikes counter for Youtube videos. Optionaly ratio bar with configurable colors. Data sources controlled in extension setting
https://nradiowave.ru/webdev/
GNU General Public License v3.0
84 stars 3 forks source link

[redacted] #1

Closed aryavsaigal closed 2 years ago

aryavsaigal commented 2 years ago

[redacted]

NC22 commented 2 years ago

I would like to apologise on behalf of all people who brigaded your extension. Brigading isn't nice to do and we should've communicated to you peacefully.

Hi. Thank you for response. sad that author started from that, instead of notify here or email, but its ok.

Please don't try to deny you didn't use the API, I had looked through your source code and you used it as a fallback.

I'm not denying that. I mentioned that in conversation https://catface.ru/userfiles/media/udata_1638058127_nyrrlltj.png

current version 1.1.1.2 works without unauthored apis, I'll add list of APIs and links to original projects to Readme \ description \ and some optional notices in popup sentiment section if I bring it back in some way. If you \ author (?) allow that

I hope you understand this, you don't need to change your extension name, and feel free to use the API again (with some attribution), but I hope you learn from this mistake, because at least we are.

Ok Thank you. I already sended earlier some changes - wanted to add prefix "KellyC", but this type of updates takes time for chrome ex. moderators

Any way again big thank you found time to write here!

aryavsaigal commented 2 years ago

[redacted]

NC22 commented 2 years ago

This seems cool, I remember Dmitry said it was ok if you used his API, but I'm not sure, feel free to open a question on github to ask if you ever want to, or let me know I I can ask him myself.

Thanks. I added a link to the RYD project to the readme. I think it would be fair to say that it was used.

I will post a discord ad to ask everyone to remove their one star reviews if possible.

Thanks. I can understand if Dmitry wont remove his review and conversation. Only thing that in some anwers he and few others appelate on false information (may be he wasnt clear enough that problem was in name \ credit), tell that I just copypaste code. I cant accept that, and will keep my anwers too for this cases https://catface.ru/userfiles/media/udata_1638094890_pfcwjvyd.png

aryavsaigal commented 2 years ago

Fair, there was some misunderstanding here, I've requested them to remove the reviews if they are able to, hopefully everything is fine now

Anarios commented 2 years ago

Hi, wanted to join the apology. From my point of view (and rushed decision) it looked like you're sitting in our the discord channel (because your github repo history clean-up happened right after I wrote in discord), and instead of just writing "Hey guys, sorry, lets make this right" - silently deleting history.

So it looked like you used the API (so clearly knew about us), used the same name, and didn't even mention original project.

To be clear - I never said that your current extension is a copy-paste of my code. I even mentioned good code quality. But - exactly as I was looking through past commits and saw something familiar - the history got deleted. So I said "feels like at the start it was just a copy-paste, but now history is deleted, so not completely sure"

So yeah, this was a misjudgment by me, I deleted all my reviews and comments and asked others to do the same.

Good luck to you and your extension.

NC22 commented 2 years ago

it looked like you're sitting in our the discord channel (because your github repo history clean-up happened right after I wrote in discord), and instead of just writing "Hey guys, sorry, lets make this right" - silently deleting history.

oh, may be. Before I reset github repository this already looked like some kind of brigade move. It wasnt just your response in reviews already at that moment. I not really familar with discord. I tried to register later (my nickname @nradiowave) to figureout where this started. There was some suggestions to open issue by DARKDRAGON532 before reviews to come https://discord.com/channels/909435648170160229/909435648665071660/914159619985776640 if I was there it really wasnt that hard to just response, but I found this thread very late

So it looked like you used the API (so clearly knew about us), used the same name, and didn't even mention original project.

Yes, I understand. Sorry. Good luck

NC22 commented 2 years ago

@Anarios @DARKDRAGON532

That seems cool, I remember Dmitri saying that it's fine if you used his API, but I'm not sure, feel free to open an issue on github to ask if you ever wish to, or let me know, I can ask him myself.

Hello. I reworked data providers controller for next version of my extension, so now it would be pretty clear for user, where data came from.

Example of how it looks \ all currently used APIs listed in readme. Will be listed in description too

https://github.com/NC22/KellyC-Return-YouTube-Dislikes

Optionaly requests for counting user actions (like \ dislike) for any driver can be implemented via callbacks. As I understand current version of API not support actions, so I disable this function for ryda driver for now. When this features be ready, I'll recheck out.

Every api driver in options listed with description \ home page of project

Return Youtube Dislike API driver description can be found here :

https://github.com/NC22/KellyC-Return-YouTube-Dislikes/blob/main/lib/api/ryda.js https://github.com/NC22/KellyC-Return-YouTube-Dislikes/blob/main/_locales/en/messages.json#L39 https://github.com/NC22/KellyC-Return-YouTube-Dislikes/blob/main/_locales/ru/messages.json#L45

If this variant of credits is acceptable I'll include ryda controller to next prod version.

aryavsaigal commented 2 years ago

Optionaly requests for counting user actions (like \ dislike) for any driver can be implemented via callbacks. As I understand current version of API not support actions, so I disable this function for ryda driver for now. When this features be ready, I'll recheck out.

We will be implementing some authentication for sending like/dislike data so not sure how you would be able to implement that into your own extension.

If this variant of credits is acceptable I'll include ryda controller to next prod version.

it seems fine to me, but you should wait for Anarios' response.

NC22 commented 2 years ago

@DARKDRAGON532

We will be implementing some authentication for sending like/dislike data so not sure how you would be able to implement that into your own extension

interesting. For example SponsorBlock uses sha256 hash as userId and then identify actions by that id \ limit some requests from server side. Also all data is unpersonalized during requests (videoId \ userid) because of hash.

https://github.com/NC22/KellyC-Return-YouTube-Dislikes/blob/main/lib/api/sponsorBlock.js#L61

but of course, may be it needs more complex system in your case

Anarios commented 2 years ago

If this variant of credits is acceptable I'll include ryda controller to next prod version.

Looks nice to me, I'll update you once our API starts accepting user votes, currently post methods are just a placeholder.

aryavsaigal commented 2 years ago

We're accepting user votes, unfortunately there arent any formal documentation but you can read the content and background script and understand how to do it

NC22 commented 2 years ago

@DARKDRAGON532

thanks, already added implementation few days ago according to Anarios source code, still testing how quickly votes are added to cached data after vote requests \ memory usage, but overall the voting actions \ registration is accepted without any issues and works fine. I keeped same behaviour, so registration request called only once per user, then just calls on vote actions. https://github.com/NC22/KellyC-Return-YouTube-Dislikes/blob/main/extension/lib/api/ryda.js

NC22 commented 2 years ago

@Anarios

Здравствуйте. Пару дней стал наблюдать, что с некоторых провайдеров (конкретно у меня Ростелеком) из РФ стал пропадать доступ к сайтам без явной отметки в списках блокировок Роскомнадзора. Исключением не стало и API https://returnyoutubedislikeapi.com/ запросы проходят не всегда. Мб у сервиса появились какие-либо зеркала \ сервисы-бекапы баз данных за это время или проект все еще закрытый? Пока единственный комфортный для себя вариант нашел, использовать свой сервер (https://catface.ru/) в качестве сервера кеширования для returnyoutubedislikeapi т.к. доступ к хосту с него все еще есть.

Сделал кеш на запросы по 350 минут для каждого видео, запросы на returnyoutubedislikeapi идут только если человек использует локаль Ru чтобы исключить лишний трафик. Текущая реализация бека - https://catface.ru/userfiles/media/udata_1650702417_qyjsbiuy.zip

Пока использую персонально в своих целях без привязки к рабочей версии расширения. Можно ли добавить этот "ретранслятор" себе в расширение в качестве альтернативного источника или возможно у вас есть какие-то более надежные решения для альтернативных подключений ? (сервер у меня самый примитивный так что большой трафик даже в качестве прокси врядли потянет)

Anarios commented 2 years ago

без явной отметки в списках блокировок Роскомнадзора

У нас cloudflare, и их айпишники порой ловят бан от Роскомпозора, из-за того что соседствуют с запрещёнными сайтами :(

Ничего против кэширующего прокси не имею, наборот - даже за. Начнёшь упираться в лимит запросов (429-е respons-ы появятся) - пиши, подниму лимит.

"или возможно у вас есть какие-то более надежные решения для альтернативных подключений" - планирую добавить несколько зеркал. Отпишусь как сделаю

NC22 commented 2 years ago

@Anarios понял, спасибо !