NCAR / ADF

A unified collection of python scripts used to generate standard plots from CAM outputs.
Creative Commons Attribution 4.0 International
35 stars 29 forks source link

Calipso diags #245

Open brianpm opened 1 year ago

brianpm commented 1 year ago

Trying to incorporate CALIPSO observations into ADF.

The CALIPSO climo file is currently here: /glade/work/brianpm/obs_data_for_adf/CALIPSO_GOCCP_3.1.2_climo_200606-202012.nc

This PR modifies the adf_variable_defaults.yaml file to include the CALIPSO variables.

In doing this, I realized that CLD_CAL has a different vertical coordinate (cosp_ht in CAM). This causes trouble when we hard-code to lev. I have started to make modifications to check for any vertical coordinate by having a list of known vertical coordinates in plotting_functions.py.

I think I've got the code working for zonal and meridional plots.

BUT something strange is going on in my testing. ADF seems to be using the same data for both the model and the observations. Also, the zonal and meridional plots of CLD_CAL are upside down because it's height and not pressure. I will look into these, but if anyone has time to take a look at what I'm doing here, I'd very much appreciate input. (I also need to fix my change to the amwg_table.py to be consistent with the other changes.)

brianpm commented 1 year ago

The problem I mentioned above was because of typos that got propagated from my temporal_averagin branch. I corrected those as part of #241 and merged that branch into this branch. I believe it should be ready for review now.

brianpm commented 1 year ago

Just FYI, I had to make a few more changes within this branch to get ADF to successfully run.