search

NCAR / CESM_postprocessing

Project repository for the CESM python based post-processing code, documentation and issues tracking.
77 stars 45 forks source link

Changes needed to get more definitions working with PyConform #137

Closed sherimickelson closed 6 years ago

sherimickelson commented 6 years ago

Includes several changes, but most modify the pyconform input json files to include the correct time-invariarant variables for the final output files to be cf compliant.

sherimickelson commented 6 years ago

I have tested with a slightly older version. The test with the master should finish early this afternoon. The changes are to low level conform files and I anticipate it still working with the master, but I will send a confirmation when it completes.

On Thu, Mar 22, 2018 at 9:42 AM, Alice Bertini notifications@github.com wrote:

@bertinia commented on this pull request.

@sherimickelson https://github.com/sherimickelson - have you tested with the most current master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NCAR/CESM_postprocessing/pull/137#pullrequestreview-106177488, or mute the thread https://github.com/notifications/unsubscribe-auth/AHs__-NGrhp-g2vFyBIkYWQHtIhxmQW4ks5tg8ZrgaJpZM4S3QFL .

sherimickelson commented 6 years ago

Tests look good and it should be okay to check this in. It is not critical to update the system copies with these changes. They can wait until the next update that's needed.

On Thu, Mar 22, 2018 at 9:48 AM, Sheri Mickelson mickelso@ucar.edu wrote:

I have tested with a slightly older version. The test with the master should finish early this afternoon. The changes are to low level conform files and I anticipate it still working with the master, but I will send a confirmation when it completes.

On Thu, Mar 22, 2018 at 9:42 AM, Alice Bertini notifications@github.com wrote:

@bertinia commented on this pull request.

@sherimickelson https://github.com/sherimickelson - have you tested with the most current master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NCAR/CESM_postprocessing/pull/137#pullrequestreview-106177488, or mute the thread https://github.com/notifications/unsubscribe-auth/AHs__-NGrhp-g2vFyBIkYWQHtIhxmQW4ks5tg8ZrgaJpZM4S3QFL .

bertinia commented 6 years ago

Merging in github master but not updating common virtualenvs on cheyenne and geyser until more pyConform changes are integrated and tested.