search

NCAR / CESM_postprocessing

Project repository for the CESM python based post-processing code, documentation and issues tracking.
77 stars 45 forks source link

uncomment the time_period_freq get global attribute #156

Closed bertinia closed 6 years ago

bertinia commented 6 years ago

The chunking.py code had commented out the code to get the time_period_freq netcdf global attribute from the first history slice file for a given output stream. This was to allow for older datasets that did not have this attribute. @sherimickelson - is this commented out code an artifact from some of your testing?

Tested with ocean BGC data where the pop.h stream was set to annual means output rather than the default monthly means.

sherimickelson commented 6 years ago

Have you tested this with CISM data? I think I may have commented this code out because it hung on that type of data.

On Sat, Jun 16, 2018 at 1:26 PM Alice Bertini notifications@github.com wrote:

@bertinia https://github.com/bertinia requested your review on: NCAR/CESM_postprocessing#156 https://github.com/NCAR/CESM_postprocessing/pull/156 uncomment the time_period_freq get global attribute.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NCAR/CESM_postprocessing/pull/156#event-1684753332, or mute the thread https://github.com/notifications/unsubscribe-auth/AHs__9CI2-33joJCK0rZbK4354Oflwjvks5t9VvSgaJpZM4Uqljq .

bertinia commented 6 years ago

@sherimickelson - successfully tested with 10 years (1995-2005) of data from b.e20.BHIST.f09_g17.20thC.297_05 for monthly atm, lnd, rof, ocn, ice and annual glc.