Adding a new empty file

NCAR / CUPiD

CUPiD is a “one stop shop” that enables and integrates timeseries file generation, data standardization, diagnostics, and metrics from all CESM components.

https://ncar.github.io/CUPiD/

Apache License 2.0

25 stars 24 forks source link

Adding a new empty file #114

Closed mnlevy1981 closed 3 months ago

mnlevy1981 commented 4 months ago

Trying to test an update to the PR Tasks Completed Check action

All Submissions:

[x] Have you followed the guidelines in our Contributer's Guide](https://github.com/NCAR/CUPiD/wiki/Contributor's-Guide) (including the pre-commit check)?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[ ] Does your submission pass tests?
[ ] Have you lint your code locally prior to submission?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

mnlevy1981 commented 4 months ago

I'm still seeing

GITHUB_TOKEN Permissions
  Checks: read
  Metadata: read

which doesn't seem right, given tasklist_completed.yml contains

    permissions:
      checks: write

I'll keep digging in, but we may want to consider the other tasklist checker action instead?

mnlevy1981 commented 4 months ago

(for the record, I updated the permissions based on https://github.com/kentaro-m/task-completed-checker-action/issues/62#issuecomment-1714550927 )

TeaganKing commented 3 months ago

Is it okay to close this PR, or did you want to do more testing with it @mnlevy1981 ?

I'm still waiting on hearing back from Joel about implementing the task list checker app within the NCAR org.

mnlevy1981 commented 3 months ago

Let's close this and revisit it later when we have a better idea of how to get a task list checker to work :)