The smoother mod is not functional in DART Manhattan. This pull request removes the smoother module, references to smoother_nml in input nmls, and the smoother.rst docs.
Motivation:
There are people using the smoother, who are using Lanai. For prototyping a Manhattan smoother, it would be good to remove the dead smoother code.
Removes unneeded and potentially confusing logic in filter_mod.
Stop compiling a module that is never used every time we build filter.
Fixes issue
Fixes #479
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[x] Removal of dead code
Documentation changes needed?
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
Tests
Please describe any tests you ran to verify your changes.
Build dart executables.
Checklist for merging
[x] Updated changelog entry
[x] Documentation updated
[x] Update conf.py
Checklist for release
[x] Merge into main
[x] Create release from the main branch with appropriate tag
[x] Delete feature-branch
Testing Datasets
[ ] Dataset needed for testing available upon request
Description:
The smoother mod is not functional in DART Manhattan. This pull request removes the smoother module, references to smoother_nml in input nmls, and the smoother.rst docs.
Motivation:
Fixes issue
Fixes #479
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Checklist for merging
Checklist for release
Testing Datasets