NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
196 stars 145 forks source link

Mom6 Add check for obs_too_deep #492

Closed hkershaw-brown closed 1 year ago

hkershaw-brown commented 1 year ago

Description:

Fixes issue

Fixes #490

Types of changes

Documentation changes needed?

Tests

Please describe any tests you ran to verify your changes. Running CESM-MOM6 with DART /glade/scratch/hkershaw/c.T62_g16.Alper.ens3/run

Checklist for merging

Checklist for release

Testing Datasets

hkershaw-brown commented 1 year ago

@hkershaw-brown what's the motivation behind the changes to the nml? Are these related to the obs_too_deep catch? Or just the nml values you used for your test case?

If the latter should they be in this PR?

The nml changes are more sensible defaults for MOM6 the single_file_in/out = .true. that was there caused some problems single_file_in = .true. filter errors out because it is expecting a members directory edit: dimension single_file_out = .true. no error, but filter overwrites the existing restart files, a bunch of MOM6 info gets removed, MOM6 can't restart.

c.e22.GMOM.T62_g16.nuopc.001 is a case specific name, I switched it to a generic name mom6.static.nc

assimilate_these_obs_types is a list of the obs from the World Ocean Data base

init_time_days/seconds = -1 use the model time

I'd like to keep the nml changes in this PR, since they are needed for running DART with CESM-MOM6 and real obs.

The trace execution and ens_sizechanges can be removed.