NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
189 stars 142 forks source link

Update params #521

Closed syha closed 1 year ago

syha commented 1 year ago

Description:

Parameters are updated in model_mod.f90 to be consistent with those in the MPAS-A model (Version 7+).

Fixes issue

fixes #251 theta_m and pressure use rvord (=1.608362) instead of 1.61. cp is now updated from 1003.0 to 1004.5 and cv is changed from 716.0 to 717.5.

Types of changes

Documentation changes needed?

Tests

In 2-member tests with a single obs for sounding temperature at 700 hPa, new parameters changed all the analysis variables.

Checklist for merging

Checklist for release

Testing Datasets

hkershaw-brown commented 1 year ago

MPAS-A model (Version 5+) https://github.com/NCAR/DART/pull/429#issuecomment-1319351693

kdraeder commented 1 year ago

@soyoung closed #429 because the original pressure calculation appears to be correct, but the commits to include a new qv^2 term seem to still be in this PR. E.g. Bug fix for full pressure with the additional term for qv^2.

hkershaw-brown commented 1 year ago

closing - will redo without the Jedi commits.