mpas_atm model_mod constants updated to match version 5+ of MPAS - Githubissues

NCAR / DART

Data Assimilation Research Testbed

https://dart.ucar.edu/

Apache License 2.0

189 stars 142 forks source link

mpas_atm model_mod constants updated to match version 5+ of MPAS #527

Closed hkershaw-brown closed 1 year ago

hkershaw-brown commented 1 year ago

Description:

mpas updated the constants in v5: https://github.com/MPAS-Dev/MPAS-Model/commit/d2b19b6237e98f33d20e62428dcdf044b5106f2a This fix is consistent with latest version of MPAS: v8.0.1

updated model_mod constants:

cp, cv, rvord
theta_m and pressure use rvord (=1.608362) instead of 1.61

rho is dry air density - comments changed to reflect this.

Fixes issue

fixes #251

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Documentation changes needed?

[x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Checklist for merging

[ ] Updated changelog entry
[ ] Documentation updated
[ ] Update conf.py

Checklist for release

[ ] Merge into main
[ ] Create release from the main branch with appropriate tag
[ ] Delete feature-branch

Testing Datasets

[ ] Dataset needed for testing available upon request
[ ] Dataset download instructions included
[x] No dataset needed

hkershaw-brown commented 1 year ago

note to reviewers: the docs build fail is due to issue #526