NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
195 stars 145 forks source link

Cam fv small fixes #529

Closed kdraeder closed 1 year ago

kdraeder commented 1 year ago

Description:

Several small independent upgrades to cam-fv shell scripts, that have accumulated over the past months and should be committed before further work in my clone. They address the definition of a temp directory, checking the existence of inflation files, and defining RUNDIR at the right place.

Fixes issue

None

Types of changes

Documentation changes needed?

None

Tests

I ran the setup scripts and they set up cases correctly.

Checklist for merging

Checklist for release

Testing Datasets

hkershaw-brown commented 1 year ago

Hi @kdraeder These fixes look good, but you have some merges from various branches in the commits. Do you have half and hour or so to meet and we can fix your git history?

kdraeder commented 1 year ago

Do you have much lined up for your office hours? Other times can work too. Thanks! Kevin

On Thu, Aug 17, 2023 at 7:02 AM Helen Kershaw @.***> wrote:

Hi @kdraeder https://github.com/kdraeder These fixes look good, but you have some merges from various branches in the commits. Do you have half and hour or so to meet and we can fix your git history?

— Reply to this email directly, view it on GitHub https://github.com/NCAR/DART/pull/529#issuecomment-1682247449, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFFGEAOQLOZ35UBIRKPXJDXVYI5BANCNFSM6AAAAAA3STCIVE . You are receiving this because you were mentioned.Message ID: @.***>

hkershaw-brown commented 1 year ago

not yet! swing on by this afternoon.

hkershaw-brown commented 1 year ago

@hkershaw-brown maybe bundle with fix for #530

kdraeder commented 1 year ago

Whatever's convenient for you. None of these are holding me back.

On Fri, Aug 18, 2023 at 7:57 AM Helen Kershaw @.***> wrote:

@hkershaw-brown https://github.com/hkershaw-brown maybe bundle with fix for #530 https://github.com/NCAR/DART/issues/530

— Reply to this email directly, view it on GitHub https://github.com/NCAR/DART/pull/529#issuecomment-1683961314, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFFGEF2TXKBD2RYPJNLADLXV5YDVANCNFSM6AAAAAA3STCIVE . You are receiving this because you were mentioned.Message ID: @.***>