Added get_channel to obs_def_rttov13_mod.f90

ann-norcio commented 1 year ago

Description:

radiance_obs_seq_to_netcdf with rttov13 failed to compile with error #6580: Name in only-list does not exist or is not accessible [GET_CHANNEL]. Fix: Added public get_channel to obs_def_rttov13_mod.f90 to compile WRF successfully.

Fixes issue

fixes #532

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Documentation changes needed?

[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.

Tests

Add radiance_obs_seq_to_netcdf to ./quickbuild.sh. Then, run ./quickbuild.sh radiance_obs_seq_to_netcdf on DART/wrf/work.

Checklist for merging

[ ] Updated changelog entry
[ ] Documentation updated
[ ] Update conf.py

Checklist for release

[ ] Merge into main
[ ] Create release from the main branch with appropriate tag
[ ] Delete feature-branch

Testing Datasets

[ ] Dataset needed for testing available upon request
[ ] Dataset download instructions included
[X] No dataset needed

mjs2369 commented 1 year ago

@hkershaw-brown we didn't push Ann's changes to /DART/models/wrf/work/quickbuild.sh

I didn't know whether or not we wanted to build this program every time with WRF, but now I'm thinking that there's probably no reason not to.

Should she commit and push her edit for that?

hkershaw-brown commented 1 year ago

@hkershaw-brown we didn't push Ann's changes to /DART/models/wrf/work/quickbuild.sh

I didn't know whether or not we wanted to build this program every time with WRF, but now I'm thinking that there's probably no reason not to.

Should she commit and push her edit for that?

So we don't want to have radiance_obs_seq_to_netcdf build by default because it requires the rttov library.

hkershaw-brown commented 1 year ago

@ann-norcio @mjs2369 I merged this pull request into #541 - since we have two single line rttov build fixes to go into main.

NCAR / DART