Closed hsanter closed 10 months ago
good sleuthing. could the fix be as simple as just removing lines 305 and 306? restrict_by_location will have been set to true or false already in lines 224-231. if it's already true, just leave it alone?
edit: true, false - sigh, got them backwards in my first stab at this comment.
I think that would work just as well, yup!
actually, for clarity i might suggest that the code set restrict_by_location to false around line 223, before the if block. then the following two code blocks can set it to true if they are entered, and do nothing if they are not. there are two alternate ways of setting the location limits and the logic might be more obvious if it was fixed this way.
That sounds like a clearer fix - so in summary,
so that restrict_by_location is set to false by default, set to true if the 1d or 2d location inputs are provided, and we still don't allow both to be set because of the if block at lines 237-240.
On Tue, Sep 26, 2023 at 4:57 PM nancy collins @.***> wrote:
actually, for clarity i might suggest that the code set restrict_by_location to false around line 223, before the if block. then the following two code blocks can set it to true if they are entered, and do nothing if they are not. there are two alternate ways of setting the location limits and the logic might be more obvious if it was fixed this way.
— Reply to this email directly, view it on GitHub https://github.com/NCAR/DART/issues/547#issuecomment-1736414051, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALSHC2XKCPUZJBOJMCPCPBLX4NMTXANCNFSM6AAAAAA5IC6XBU . You are receiving this because you modified the open/close state.Message ID: @.***>
-- Henry Santer Department of Atmospheric and Oceanic Science University of Maryland, College Park (305) 562-0503
yep, that's it exactly.
:bug:
Describe the bug