search

NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
187 stars 140 forks source link

module_initialize checks, but no module initialization in random_seq_mod.f90 #548

Open hkershaw-brown opened 11 months ago

hkershaw-brown commented 11 months ago

This commit: https://github.com/NCAR/DART/commit/ec49b7c30e7ec9ed658148d0e4f8cb19cca022ee#diff-af80bdbb619272f50d31adc43bc203acc271df1016944454c4c9fc8b9f862172 removed calls to register_module

so random_sequence_mod has a module_initialized check, but an empty initialize_subroutine_module

https://github.com/NCAR/DART/blob/6eeb4539f1d140c3184c2f9521a1b3bdf9d3396f/assimilation_code/modules/utilities/random_seq_mod.f90#L294-L300

This came up while looking at random_seq_mod.f90 https://github.com/NCAR/DART/issues/499 There may be other modules with this behaviour.

Edit: there are https://github.com/NCAR/DART/blob/6eeb4539f1d140c3184c2f9521a1b3bdf9d3396f/assimilation_code/modules/assimilation/obs_model_mod.f90#L49-L53

https://github.com/NCAR/DART/blob/6eeb4539f1d140c3184c2f9521a1b3bdf9d3396f/assimilation_code/modules/utilities/sort_mod.f90#L85-L91

https://github.com/NCAR/DART/blob/6eeb4539f1d140c3184c2f9521a1b3bdf9d3396f/assimilation_code/programs/compare_states/compare_states.f90#L414-L418 (this is program)

nancycollins commented 11 months ago

just curious - are you suggesting removing the initialize_module routines since they currently do nothing? like if a module needs to be edited for other actual fixes? or someday just going through and removing them all in a single commit? i see the 'back burner' label so this is just info for the future.

history: these used to call register_module which logged the SVN revision of each module as it ran, but with GIT you can't do that so it was removed. having an init routine does leave a place to add code if some initialization is needed in the future, but it also could all be removed in the interest of supporting fewer lines of code and cleaning things up.

hkershaw-brown commented 11 months ago

not really suggesting anything at the moment. Just a note on dead code.