NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
187 stars 140 forks source link

ran_unif Mersenne twister test: Resolution to Issue #499 #549

Closed c-merchant closed 10 months ago

c-merchant commented 11 months ago

Description:

Created ran_twist function that preserves the integer from ran_unif Mersenne twister PRNG. Created test_ran_unif that runs ran_twist with a known seed, compare the integers produced against a reference solution for the Mersenne Twister.

Fixes issue

fixes #499

Types of changes

Documentation changes needed?

Tests

Please describe any tests you ran to verify your changes. I ran ./quickbuild.sh and ./runall.sh in ~/DART/developer_tests/random_seq/work

Checklist for merging

Checklist for release

Testing Datasets

hkershaw-brown commented 11 months ago

@c-merchant looks good Charlotte! Produces a fail for CCE 15 on Derecho, pass for other compilers. There's some setup with ntests, and "save values for plotting" that we don't need for this test (the test passes or it fails). I'm going to go ahead and strip those out and we can bundle this with the next release.

Cheers, Helen

hkershaw-brown commented 10 months ago

@hkershaw-brown you missed these two commits off this pull request https://github.com/NCAR/DART/compare/main...499