Closed c-merchant closed 8 months ago
Thanks for this, I've not reviewed this closely, but one thing that is missing from the pull request is to remove the nc_check subroutine from utilities_mod.f90
@mjs2369 we'll bundle this with #593 for the next release
Description:
This PR replaces utilities_mod::nc_check with netcdf_utilities_mod::nc_check in: models/mpas_atm/mpas_dart_obs_preprocess.f90 models/mpas_atm/update_bc.f90 models/wrf_hydro/create_identity_streamflow_obs.f90 assimilation_code/programs/compute_error/compute_error.f90 observations/forward_operators/obs_def_GRACE_mod.f90 observations/obs_converters/utilities/obs_seq_utilities_mod.f90 observations/obs_converters/USGS/convert_streamflow.f90 models/pe2lyr/model_mod.f90 models/mpas_ocn/model_mod_check.f90 models/pe2lyr/model_mod.f90 models/mpas_ocn/model_mod_check.f90 models/am2/model_mod.f90 models/forced_barot/obs/obs_mod.f90 models/NCOMMAS/model_mod.f90 models/rose/model_mod.f90
Fixes issue
fixes #336
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes. I compiled DART and ran ./quickbuild.sh for Lorenz-63
Checklist for merging
Checklist for release
Testing Datasets