search

NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
184 stars 139 forks source link

bug: AIRS converter prints wrong number of obs converted and has bad input.nml defaults #596

Closed nancycollins closed 7 months ago

nancycollins commented 7 months ago

:bug: AIRS converter prints one too many obs converted, and has bad input.nml defaults

Describe the bug

  1. Run the AIRS converter, look at the number of obs printed
  2. the output really has only N-1 obs
  3. Also, the input.nml defaults cull out all obs (bad choice for defaults) and has -60 to 60 as the latitudes which excludes obs near the poles (in one test case all the obs were near the poles and i got no obs output).

Error Messages

If the converter converts 0 obs, it prints out 1 obs converted which is confusing.

Which model(s) are you working with?

AIRS obs converter

Have you modified the DART code?

Yes - i will file a pull request soon.

hkershaw-brown commented 7 months ago

just to clarify:

Have you modified the DART code?

Yes - i will file a pull request soon.

The bug is in main