NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
184 stars 139 forks source link

fix print of number of obs converted, and make input.nml defaults better #597

Closed nancycollins closed 7 months ago

nancycollins commented 7 months ago

the convert_airs_L2 converter was printing 1 more obs converted than was actually done.

also, the settings for the convert_airs_L2 namelist thinned out all the obs. change the defaults to include all possible obs, including all latitudes, and give an example filename for input instead of a list name. the input file isn't in our repo, but it might help a user see what kind of filename they're looking for.

Description:

fix printout of number of obs converted to be right. also change namelist defaults to not thin out all obs

Fixes issue

fixes #596

Types of changes

Documentation changes needed?

Tests

i built and ran this with my copy of the updated HDF_EOS libraries and it printed out the correct number of obs. it also didn't thin them all out.

Checklist for merging

Checklist for release

Testing Datasets

nancycollins commented 7 months ago

p.s. i linked this with the original hdf-eos library and got the 'file not found' error. i linked it with the hdf-eos.patch version of the library and it ran fine.