search

NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
196 stars 145 forks source link

clamp or fail - mpas and wrf model_mod have this, it is ignored by dart #624

Open hkershaw-brown opened 9 months ago

hkershaw-brown commented 9 months ago

I don't think clamp_or_fail is used: ☠️ https://github.com/NCAR/DART/blob/52e6e45f8f6ff07a90227766c8de72f1474162f2/models/wrf/model_mod.f90#L343

https://github.com/search?q=repo%3ANCAR%2FDART%20clamp_or_fail&type=code

clamp_or_fail not passed to state structure No fail in clamp_variable

https://github.com/NCAR/DART/blob/52e6e45f8f6ff07a90227766c8de72f1474162f2/assimilation_code/modules/io/direct_netcdf_mod.f90#L1448-L1534

Originally posted by @hkershaw-brown in https://github.com/NCAR/DART/issues/404#issuecomment-1894552566

hkershaw-brown commented 1 week ago

mpas_atm clamp or fail called in https://github.com/NCAR/DART/blob/e2188646b97573f198c66f7ea63482ebc34afa11/models/mpas_atm/model_mod.f90#L2312 on already clamped data?