Remove calls to no-op routines in ensemble manager

ann-norcio commented 5 months ago

Description:

Removed the following no-op routines form ensemble manager: prepare_to_write_to_vars, prepare_to_write_to_copies, & prepare_to_read_from_vars, prepare_to_read_from_copies, prepare_to_update_vars, & prepare_to_update_copies

Fixes issue

Fixes https://github.com/NCAR/DART/issues/620

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Documentation update
[X] Dead code removal

Documentation changes needed?

[ ] My change requires a change to the documentation.
- [X] I have updated the documentation accordingly.

Tests

Ran build_everything for branch, tested with lorenz_96 & 63 models.

Checklist for merging

[ ] Updated changelog entry
[ ] Documentation updated
[ ] Update conf.py

Checklist for release

[ ] Merge into main
[ ] Create release from the main branch with appropriate tag
[ ] Delete feature-branch

Testing Datasets

[ ] Dataset needed for testing available upon request
[ ] Dataset download instructions included
[ ] No dataset needed

hkershaw-brown commented 5 months ago

@ann-norcio this looks good. Your git config is not set up with your GitHub account (email or no-reply email) Before we merge this pull request, we'll rewrite the history so these contributions show up as 'official contributions' to dart.

ann-norcio commented 5 months ago

@hkershaw-brown commited changes to remove ens_handle%valid

hkershaw-brown commented 5 months ago

Nice work Ann, I'll take a look at this when I come back from PTO. Have a good weekend!

NCAR / DART