search

NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
184 stars 138 forks source link

MPAS 8 vs 7 #668

Open hkershaw-brown opened 2 months ago

hkershaw-brown commented 2 months ago

Collection of MPAS 8 vs MPAS 7 differences.

User reported problems with MPAS 8 and DART:

hkershaw-brown commented 2 months ago

Note from Chris R. on mpas start up calculation of reconstructed u,v

Looks like the computation is done in this code: https://github.com/MPAS-Dev/MPAS-Model/blob/master/src/operators/mpas_vector_reconstruction.F mpas_vector_reconstruction.F

hkershaw-brown commented 2 months ago

Note from Soyoung to add fields back into files First, you should do 'make clean' with core=init_atmosphere_model, then with atmosphere_model in your MPAS model directory. Then, for init_atmosphere_model, Add these two lines right below https://github.com/MPAS-Dev/MPAS-Model/blob/hotfix-v8.0.1/src/core_init_atmosphere/Registry.xml#L548.

<var name="uReconstructZonal" packages="met_stage_out"/>
<var name="uReconstructMeridional" packages="met_stage_out"/>

Then, recompile your init_atmosphere_model.

Next, for core=atmosphere_model, add these two lines right below https://github.com/MPAS-Dev/MPAS-Model/blob/hotfix-v8.0.1/src/core_atmosphere/Registry.xml#L634.

<var name="uReconstructZonal"/>
<var name="uReconstructMeridional/">

With that, recompile your atmosphere_model.

syha commented 2 months ago

In fact, we already have the MPAS codes in DART/models/mpas_atm/get_reconstruct_mod.f90, which are called from the compute_u_with_rbf module in model_mod.f90 when use_u_for_wind = .true. So, technically, we can reconstruct uReconstructZonal and uReconstructMeridional from the edge wind 'u' in the current mpas_atm/model_mod. But there are several other parameters and the following I/O structures we may want to update as well (because of the updates on the model side). For instance, the model no longer supports or saves lbc_ur and lbc_vr in the lateral boundary conditions. So we need to remove everything related to them. In brief, the current mpas-atm in DART needs major upgrades, especially for regional applications.

hkershaw-brown commented 2 months ago

Thanks for the info @syha

Do you know which version of DART & version of MPAS NSSL is using/used? Also which version of MPAS JEDI is using (I think it is a modified version of 7.0)? It would be good to get the big picture on data assimilation with MPAS.

syha commented 2 months ago

No problem. NSSL uses their own version of the MPAS model based on V8.0 for their own physics suite + new I/O stream. Their DART is basically the version I had tried to push into this repository but was not allowed to, plus some bug fixes and updates for the compatibility with the regional model. So the current mpas-atm in DART is quite outdated and needs comprehensive updates to work with the recent version of the model. If you guys can work with me, I guess we can get all the updates and tests done in a month or so, but I don't have time to do it alone. The MPAS-JEDI uses its own MPAS version customized for the JEDI system. It's a bit too much to write all of them down here, I'd better explain to you in a meeting.

hkershaw-brown commented 2 months ago

may split this off into a separate scripting issue:

driver_mpas_dart.csh refering to out-of-date namelist option start_from_restart https://github.com/NCAR/DART/blob/4b184025498952753ac4141f36a3a7d3505cbdcb/models/mpas_atm/shell_scripts/driver_mpas_dart.csh#L374-L375

Zero documentation on docs.dart.ucar.edu for the scripting.

hkershaw-brown commented 2 months ago

todo:

Spec: mpas